[PATCH] include: spinlock.h: mark DEFINE_SPINLOCK with __always_unused

[PATCH] include: spinlock.h: mark DEFINE_SPINLOCK with __always_unused

[Ahmad Fatoum]

The spinlock stubs don't actually do anything with the spinlock_t.
To avoid the compiler warning about it add an __always_unused annotation
to the spinlock.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/linux/spinlock.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index a604e0fd090f..6f90fb1cad43 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -12,6 +12,6 @@ typedef int   spinlock_t;
 #define spin_lock_irqsave(lock, flags) do { flags = 0; } while (0)
 #define spin_unlock_irqrestore(lock, flags) do { flags = flags; } while (0)
 
-#define DEFINE_SPINLOCK(lock) spinlock_t lock
+#define DEFINE_SPINLOCK(lock) spinlock_t __always_unused lock
 
 #endif /* __LINUX_SPINLOCK_H */
-- 
2.39.2

Re: [PATCH] include: spinlock.h: mark DEFINE_SPINLOCK with __always_unused

[Sascha Hauer]

On Thu, Nov 09, 2023 at 01:29:45PM +0100, Ahmad Fatoum wrote:
> The spinlock stubs don't actually do anything with the spinlock_t.
> To avoid the compiler warning about it add an __always_unused annotation
> to the spinlock.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  include/linux/spinlock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
> index a604e0fd090f..6f90fb1cad43 100644
> --- a/include/linux/spinlock.h
> +++ b/include/linux/spinlock.h
> @@ -12,6 +12,6 @@ typedef int   spinlock_t;
>  #define spin_lock_irqsave(lock, flags) do { flags = 0; } while (0)
>  #define spin_unlock_irqrestore(lock, flags) do { flags = flags; } while (0)
>  
> -#define DEFINE_SPINLOCK(lock) spinlock_t lock
> +#define DEFINE_SPINLOCK(lock) spinlock_t __always_unused lock
>  
>  #endif /* __LINUX_SPINLOCK_H */
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |