From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 2/3] net: eqos: imx: move common stuff to probe()
Date: Fri, 10 Nov 2023 14:02:05 +0100 [thread overview]
Message-ID: <20231110130206.2172907-3-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20231110130206.2172907-1-s.hauer@pengutronix.de>
eqos_init_imx() currently is i.MX8 specific, but some stuff can be used
by i.MX9 as well. Move that to probe().
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/net/designware_imx.c | 50 ++++++++++++++++++++----------------
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/net/designware_imx.c b/drivers/net/designware_imx.c
index 00164fa7c7..13bca42c25 100644
--- a/drivers/net/designware_imx.c
+++ b/drivers/net/designware_imx.c
@@ -115,11 +115,6 @@ static int eqos_init_imx(struct device *dev, struct eqos *eqos)
struct eqos_imx_priv *priv = eqos->priv;
int ret;
- priv->dev = dev;
-
- if (of_get_property(np, "snps,rmii_refclk_ext", NULL))
- priv->rmii_refclk_ext = true;
-
if (of_device_is_compatible(np, "nxp,imx8mp-dwmac-eqos")) {
priv->intf_regmap = syscon_regmap_lookup_by_phandle(np, "intf_mode");
if (IS_ERR(priv->intf_regmap))
@@ -132,22 +127,6 @@ static int eqos_init_imx(struct device *dev, struct eqos *eqos)
}
}
- priv->num_clks = ARRAY_SIZE(imx_clks);
- priv->clks = xmalloc(priv->num_clks * sizeof(*priv->clks));
- memcpy(priv->clks, imx_clks, sizeof imx_clks);
-
- ret = clk_bulk_get(dev, priv->num_clks, priv->clks);
- if (ret) {
- dev_err(dev, "Failed to get clks: %s\n", strerror(-ret));
- return ret;
- }
-
- ret = clk_bulk_enable(priv->num_clks, priv->clks);
- if (ret) {
- dev_err(dev, "Failed to enable clks: %s\n", strerror(-ret));
- return ret;
- }
-
eqos_imx_set_interface_mode(eqos);
return 0;
@@ -166,7 +145,34 @@ static struct eqos_ops imx_ops = {
static int eqos_probe_imx(struct device *dev)
{
- return eqos_probe(dev, &imx_ops, xzalloc(sizeof(struct eqos_imx_priv)));
+ struct device_node *np = dev->device_node;
+ struct eqos_imx_priv *priv;
+ int ret;
+
+ priv = xzalloc(sizeof(*priv));
+
+ priv->dev = dev;
+
+ if (of_get_property(np, "snps,rmii_refclk_ext", NULL))
+ priv->rmii_refclk_ext = true;
+
+ priv->num_clks = ARRAY_SIZE(imx_clks);
+ priv->clks = xmalloc(priv->num_clks * sizeof(*priv->clks));
+ memcpy(priv->clks, imx_clks, sizeof imx_clks);
+
+ ret = clk_bulk_get(dev, priv->num_clks, priv->clks);
+ if (ret) {
+ dev_err(dev, "Failed to get clks: %s\n", strerror(-ret));
+ return ret;
+ }
+
+ ret = clk_bulk_enable(priv->num_clks, priv->clks);
+ if (ret) {
+ dev_err(dev, "Failed to enable clks: %s\n", strerror(-ret));
+ return ret;
+ }
+
+ return eqos_probe(dev, &imx_ops, priv);
}
static void eqos_remove_imx(struct device *dev)
--
2.39.2
next prev parent reply other threads:[~2023-11-10 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 13:02 [PATCH 0/3] Add i.MX9 EQOS networking support Sascha Hauer
2023-11-10 13:02 ` [PATCH 1/3] net: eqos: rename i.MX8 driver glue code to i.MX Sascha Hauer
2023-11-13 7:19 ` Ahmad Fatoum
2023-11-10 13:02 ` Sascha Hauer [this message]
2023-11-10 13:02 ` [PATCH 3/3] net: eqos: Add i.MX93 support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110130206.2172907-3-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox