[PATCH] usb: dwc2: use linux/spinlock.h for stubs

[PATCH] usb: dwc2: use linux/spinlock.h for stubs

[Ahmad Fatoum]

We already have dummy definitions for common spin lock operations,
so reuse them instead of defining them in the driver.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/usb/dwc2/gadget.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 00323d2d9029..3c06c438b65d 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -1,18 +1,15 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 #include <dma.h>
 #include <linux/usb/gadget.h>
+#include <linux/spinlock.h>
 #include "dwc2.h"
 
 #define to_dwc2 gadget_to_dwc2
 #define dwc2_set_bit(d, r, b)	dwc2_writel(d, (b) | dwc2_readl(d, r), r)
 #define dwc2_clear_bit(d, r, b)	dwc2_writel(d, ~(b) & dwc2_readl(d, r), r)
 
-#define spin_lock(lock)
-#define spin_unlock(lock)
 #define local_irq_save(flags)(void)(flags)
 #define local_irq_restore(flags) (void)(flags)
-#define spin_lock_irqsave(lock, flags) (void)(flags)
-#define spin_unlock_irqrestore(lock, flags) (void)(flags)
 
 static void kill_all_requests(struct dwc2 *, struct dwc2_ep *, int);
 
-- 
2.39.2

Re: [PATCH] usb: dwc2: use linux/spinlock.h for stubs

[Sascha Hauer]

On Thu, Nov 09, 2023 at 12:48:38PM +0100, Ahmad Fatoum wrote:
> We already have dummy definitions for common spin lock operations,
> so reuse them instead of defining them in the driver.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/usb/dwc2/gadget.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 00323d2d9029..3c06c438b65d 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -1,18 +1,15 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  #include <dma.h>
>  #include <linux/usb/gadget.h>
> +#include <linux/spinlock.h>
>  #include "dwc2.h"
>  
>  #define to_dwc2 gadget_to_dwc2
>  #define dwc2_set_bit(d, r, b)	dwc2_writel(d, (b) | dwc2_readl(d, r), r)
>  #define dwc2_clear_bit(d, r, b)	dwc2_writel(d, ~(b) & dwc2_readl(d, r), r)
>  
> -#define spin_lock(lock)
> -#define spin_unlock(lock)
>  #define local_irq_save(flags)(void)(flags)
>  #define local_irq_restore(flags) (void)(flags)
> -#define spin_lock_irqsave(lock, flags) (void)(flags)
> -#define spin_unlock_irqrestore(lock, flags) (void)(flags)
>  
>  static void kill_all_requests(struct dwc2 *, struct dwc2_ep *, int);
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |