From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 13 Nov 2023 13:41:55 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r2WGJ-00A0xL-0T for lore@lore.pengutronix.de; Mon, 13 Nov 2023 13:41:55 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2WGJ-0005XW-0l for lore@pengutronix.de; Mon, 13 Nov 2023 13:41:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PNhouN4vEsAj6ijq2QMakCKQ2VAJp1coj7knMtp2LTk=; b=oaRc/l5V4YVWRdCIEgF85fT0Rs BMfZMuPqHDkXjeE07FEla0lS+9Gf+N6stC78xETyx+O7KNzG2HIYd8J2qPS5VxhKOF2WGhMRt64f8 rAIcwPZ/2VtS4a14IVsPRJ5aW87dEmnzuehmr+AKW5s+8Eca6d//Ih6vzyLK8azggP4jBoJt5uJKE Bot6r+Oya1iy4TdipcL/hRVHjOt9j8jSWvErOHePw5Xjhx9+/4uelngJ6Sy0CWPIg2jediCqyrfV9 9pjUc/MQvr9bjiuqwblnNkzE1Y2TZl+6eu2ip6Lp5oIVLLlg2WarlPTLCfIfk7Kjm8fPljlu6A//1 p307YwmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2WFE-00Dyso-1n; Mon, 13 Nov 2023 12:40:48 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2WFB-00DysK-0a for barebox@lists.infradead.org; Mon, 13 Nov 2023 12:40:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2WF9-0005Ml-Vx; Mon, 13 Nov 2023 13:40:44 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2WF9-008jxF-Jb; Mon, 13 Nov 2023 13:40:43 +0100 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1r2WF9-001opA-HN; Mon, 13 Nov 2023 13:40:43 +0100 Date: Mon, 13 Nov 2023 13:40:43 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20231113124043.GP3359458@pengutronix.de> References: <20231110214421.2726093-1-a.fatoum@pengutronix.de> <20231110214421.2726093-6-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110214421.2726093-6-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231113_044045_222885_8E1B6594 X-CRM114-Status: GOOD ( 32.46 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 05/18] asm-generic: split off typeconfused readl and friends X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Fri, Nov 10, 2023 at 10:44:08PM +0100, Ahmad Fatoum wrote: > The MMIO accessors in barebox like readl have the error prone > peculiarity of accepting integer arguments to pointers automatically, > which makes it easy to confuse address and data. > > We will add an alternative less error-probe way for new code, so first s/error-probe/error-prone/ > split off the typeconfused code into a separate file. > > Signed-off-by: Ahmad Fatoum > --- > include/asm-generic/io-typeconfused.h | 75 +++++++++++++++++++++++++++ > include/asm-generic/io.h | 57 +------------------- > 2 files changed, 76 insertions(+), 56 deletions(-) > create mode 100644 include/asm-generic/io-typeconfused.h > > diff --git a/include/asm-generic/io-typeconfused.h b/include/asm-generic/io-typeconfused.h > new file mode 100644 > index 000000000000..d25ed7db2473 > --- /dev/null > +++ b/include/asm-generic/io-typeconfused.h > @@ -0,0 +1,75 @@ > +/* Generic I/O port emulation, based on MN10300 code > + * > + * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells@redhat.com) > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public Licence > + * as published by the Free Software Foundation; either version > + * 2 of the Licence, or (at your option) any later version. > + */ > +#ifndef __ASM_GENERIC_IO_TYPECONFUSED_H > +#define __ASM_GENERIC_IO_TYPECONFUSED_H > + > +#include /* for memset() and memcpy() */ > +#include > +#include > +#include > + > +/*****************************************************************************/ > +/* > + * Unlike the definitions in , these macros don't complain > + * about integer arguments and just silently cast them to pointers. This is > + * a common cause of bugs, but lots of existing code depends on this, so > + * this header is provided as a transitory measure. > + */ > + > +#ifndef __raw_readb > +#define __raw_readb(a) (__chk_io_ptr(a), *(volatile unsigned char __force *)(a)) > +#endif > + > +#ifndef __raw_readw > +#define __raw_readw(a) (__chk_io_ptr(a), *(volatile unsigned short __force *)(a)) > +#endif > + > +#ifndef __raw_readl > +#define __raw_readl(a) (__chk_io_ptr(a), *(volatile unsigned int __force *)(a)) > +#endif > + > +#ifndef readb > +#define readb __raw_readb > +#endif > + > +#ifndef readw > +#define readw(addr) __le16_to_cpu(__raw_readw(addr)) > +#endif > + > +#ifndef readl > +#define readl(addr) __le32_to_cpu(__raw_readl(addr)) > +#endif > + > +#ifndef __raw_writeb > +#define __raw_writeb(v,a) (__chk_io_ptr(a), *(volatile unsigned char __force *)(a) = (v)) > +#endif > + > +#ifndef __raw_writew > +#define __raw_writew(v,a) (__chk_io_ptr(a), *(volatile unsigned short __force *)(a) = (v)) > +#endif > + > +#ifndef __raw_writel > +#define __raw_writel(v,a) (__chk_io_ptr(a), *(volatile unsigned int __force *)(a) = (v)) > +#endif > + > +#ifndef writeb > +#define writeb __raw_writeb > +#endif > + > +#ifndef writew > +#define writew(b,addr) __raw_writew(__cpu_to_le16(b),addr) > +#endif > + > +#ifndef writel > +#define writel(b,addr) __raw_writel(__cpu_to_le32(b),addr) > +#endif > + > +#endif /* __ASM_GENERIC_IO_TYPECONFUSED_H */ > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index ab439026928a..6383d71746f1 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -15,62 +15,7 @@ > #include > #include > #include > - > -/*****************************************************************************/ > -/* > - * readX/writeX() are used to access memory mapped devices. On some > - * architectures the memory mapped IO stuff needs to be accessed > - * differently. On the simple architectures, we just read/write the > - * memory location directly. > - */ > - > -#ifndef __raw_readb > -#define __raw_readb(a) (__chk_io_ptr(a), *(volatile unsigned char __force *)(a)) > -#endif > - > -#ifndef __raw_readw > -#define __raw_readw(a) (__chk_io_ptr(a), *(volatile unsigned short __force *)(a)) > -#endif > - > -#ifndef __raw_readl > -#define __raw_readl(a) (__chk_io_ptr(a), *(volatile unsigned int __force *)(a)) > -#endif > - > -#ifndef readb > -#define readb __raw_readb > -#endif > - > -#ifndef readw > -#define readw(addr) __le16_to_cpu(__raw_readw(addr)) > -#endif > - > -#ifndef readl > -#define readl(addr) __le32_to_cpu(__raw_readl(addr)) > -#endif > - > -#ifndef __raw_writeb > -#define __raw_writeb(v,a) (__chk_io_ptr(a), *(volatile unsigned char __force *)(a) = (v)) > -#endif > - > -#ifndef __raw_writew > -#define __raw_writew(v,a) (__chk_io_ptr(a), *(volatile unsigned short __force *)(a) = (v)) > -#endif > - > -#ifndef __raw_writel > -#define __raw_writel(v,a) (__chk_io_ptr(a), *(volatile unsigned int __force *)(a) = (v)) > -#endif > - > -#ifndef writeb > -#define writeb __raw_writeb > -#endif > - > -#ifndef writew > -#define writew(b,addr) __raw_writew(__cpu_to_le16(b),addr) > -#endif > - > -#ifndef writel > -#define writel(b,addr) __raw_writel(__cpu_to_le32(b),addr) > -#endif > +#include > > #ifdef CONFIG_64BIT > static inline u64 __raw_readq(const volatile void __iomem *addr) > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |