From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Sascha Hauer <sha@pengutronix.de>
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Thorsten Scherer <T.Scherer@eckelmann.de>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
barebox@lists.infradead.org
Subject: [PATCH v2 0/2] Allow generating MAC addresses from machine ID
Date: Wed, 15 Nov 2023 10:02:39 +0100 [thread overview]
Message-ID: <20231115090238.399200-1-uwe@kleine-koenig.org> (raw)
Hello,
this series contains two patches by Ahmad that he send earlier starting
with Message-Id: <20230911155927.3786335-1-a.fatoum@pengutronix.de>.
Patch #1 was already applied back then as 9831b2e5fed8 ("common:
machine_id: support deriving app specific UUIDs").
Changes since (implicit) v1:
- fix compilation with MACHINE_ID=n (Sascha)
- fix typo in NET_ETHADDR_FROM_MACHINE_ID helptext (Thorsten)
- rename of_populate_ethaddr -> populate_ethaddr as it's not about of any more (Sascha)
On Tue, Sep 12, 2023 at 12:49:03PM +0200, Sascha Hauer wrote:
> On Mon, Sep 11, 2023 at 05:59:27PM +0200, Ahmad Fatoum wrote:
> > @@ -566,11 +568,18 @@ static int of_populate_ethaddr(void)
> >
> > ret = of_get_mac_addr_nvmem(edev->parent->of_node,
> > edev->ethaddr);
> > + if (ret && IS_ENABLED(CONFIG_NET_ETHADDR_FROM_MACHINE_ID)) {
>
> This check doesn't seem to be needed, generate_ether_addr() already
> returns -ENOSYS when this option is not enabled.
I kept this check, Ahmad already argued that is should be kept. (I only
swapped the checks to have the static one first which is IMHO more
natural.)
Best regards
Uwe
Ahmad Fatoum (2):
common: machine_id: support deriving app specific UUIDs
net: add generic MAC address derivation from machine ID
common/machine_id.c | 84 ++++++++++++++++++++++++++++++++++++++++++--
include/linux/uuid.h | 8 +++++
include/machine_id.h | 11 ++++++
include/net.h | 2 ++
net/Kconfig | 17 +++++++++
net/eth.c | 15 ++++++--
net/net.c | 49 ++++++++++++++++++++++++--
7 files changed, 179 insertions(+), 7 deletions(-)
base-commit: bc5e49335067d0c6c6e97c082a0368fe9d86b725
--
2.42.0.586.gbc5204569f7d.dirty
next reply other threads:[~2023-11-15 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 9:02 Uwe Kleine-König [this message]
2023-11-15 9:02 ` [PATCH v2 1/2] common: machine_id: support deriving app specific UUIDs Uwe Kleine-König
2023-11-15 9:02 ` [PATCH v2 2/2] net: add generic MAC address derivation from machine ID Uwe Kleine-König
2023-11-21 8:33 ` [PATCH v2 0/2] Allow generating MAC addresses " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115090238.399200-1-uwe@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=T.Scherer@eckelmann.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eagle.alexander923@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox