From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH RFC 2/3] libfile: implement read_fd counterpart to read_file
Date: Mon, 20 Nov 2023 09:37:49 +0100 [thread overview]
Message-ID: <20231120083750.3967831-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20231120083750.3967831-1-a.fatoum@pengutronix.de>
Files opened with O_TMPFILE have no name, so read_file can't be used
with them. Therefore add a read_fd function, which slurps all a file's
contents into a buffer.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/libfile.h | 2 ++
lib/libfile.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+)
diff --git a/include/libfile.h b/include/libfile.h
index a353ccfa9ea9..423e7ffec5b7 100644
--- a/include/libfile.h
+++ b/include/libfile.h
@@ -12,6 +12,8 @@ char *read_file_line(const char *fmt, ...);
void *read_file(const char *filename, size_t *size);
+void *read_fd(int fd, size_t *size);
+
int read_file_2(const char *filename, size_t *size, void **outbuf,
loff_t max_size);
diff --git a/lib/libfile.c b/lib/libfile.c
index e53ba08415a2..c257baaa2733 100644
--- a/lib/libfile.c
+++ b/lib/libfile.c
@@ -306,6 +306,50 @@ void *read_file(const char *filename, size_t *size)
}
EXPORT_SYMBOL(read_file);
+/**
+ * read_fd - read from a file descriptor to an allocated buffer
+ * @filename: The file descriptor to read
+ * @size: After successful return contains the size of the file
+ *
+ * This function reads a file descriptor from offset 0 until EOF to an
+ * allocated buffer.
+ *
+ * Return: The buffer containing the file or NULL on failure
+ */
+void *read_fd(int fd, size_t *out_size)
+{
+ off_t off;
+ ssize_t ret;
+ size_t size;
+ void *buf;
+
+ off = lseek(fd, SEEK_CUR, 0);
+ if (off >= 0) {
+ size = off;
+ off = lseek(fd, SEEK_SET, 0);
+ }
+ if (off < 0) {
+ ret = off;
+ goto close_fd;
+ }
+
+ buf = malloc(size + 3);
+ ret = read_full(fd, buf, size);
+ if (ret < 0) {
+ free(buf);
+ goto close_fd;
+ }
+
+ memset(&buf[size], '\0', 3);
+ *out_size = size;
+
+close_fd:
+ close(fd);
+
+ return ret < 0 ? NULL : buf;
+}
+EXPORT_SYMBOL(read_fd);
+
/**
* write_file - write a buffer to a file
* @filename: The filename to write
--
2.39.2
next prev parent reply other threads:[~2023-11-20 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:37 [PATCH RFC 1/3] fs: add open O_TMPFILE support Ahmad Fatoum
2023-11-20 8:37 ` Ahmad Fatoum [this message]
2023-11-20 9:49 ` [PATCH RFC 2/3] libfile: implement read_fd counterpart to read_file Yann Sionneau
2023-11-20 10:50 ` Ahmad Fatoum
2023-11-21 7:36 ` Sascha Hauer
2023-11-22 16:09 ` Ahmad Fatoum
2023-11-20 8:37 ` [PATCH RFC 3/3] uncompress: skip dentry cache in uncompress_buf_to_buf Ahmad Fatoum
2023-11-20 10:49 ` [PATCH] fixup! libfile: implement read_fd counterpart to read_file Ahmad Fatoum
2023-11-20 13:32 ` [PATCH RFC 1/3] fs: add open O_TMPFILE support Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120083750.3967831-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox