[PATCH] fixup! test: self: add JSON Web Token tests

[PATCH] fixup! test: self: add JSON Web Token tests

[Ahmad Fatoum]

test: self: jwt: use barebox_set_loglevel

For CONFIG_CONSOLE_SIMPLE or CONFIG_CONSOLE_FULL, this is equivalent,
but for CONFIG_CONSOLE_NONE, this fixes a linker error as
barebox_loglevel isn't defined in that case.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - send as fixup instead of a patch as fixed commit is still in next
---
 test/self/jwt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/test/self/jwt.c b/test/self/jwt.c
index f37b44be22b8..015a0e436736 100644
--- a/test/self/jwt.c
+++ b/test/self/jwt.c
@@ -97,8 +97,7 @@ static void test_jwt(void)
 	 * noisy, so we decrease logging a bit during their run
 	 */
 
-	old_loglevel = barebox_loglevel;
-	barebox_loglevel = MSG_CRIT;
+	old_loglevel = barebox_set_loglevel(MSG_CRIT);
 
 	jwt_rs256_mangled = strdup(jwt_rs256);
 	ch = &jwt_rs256_mangled[strlen(jwt_rs256_mangled) - 1];
@@ -152,6 +151,6 @@ static void test_jwt(void)
 		jwt_free(jwt);
 	}
 
-	barebox_loglevel = old_loglevel;
+	barebox_set_loglevel(old_loglevel);
 }
 bselftest(parser, test_jwt);
-- 
2.39.2

Re: [PATCH] fixup! test: self: add JSON Web Token tests

[Sascha Hauer]

On Wed, Nov 22, 2023 at 04:54:43PM +0100, Ahmad Fatoum wrote:
> test: self: jwt: use barebox_set_loglevel
> 
> For CONFIG_CONSOLE_SIMPLE or CONFIG_CONSOLE_FULL, this is equivalent,
> but for CONFIG_CONSOLE_NONE, this fixes a linker error as
> barebox_loglevel isn't defined in that case.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>   - send as fixup instead of a patch as fixed commit is still in next
> ---
>  test/self/jwt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/test/self/jwt.c b/test/self/jwt.c
> index f37b44be22b8..015a0e436736 100644
> --- a/test/self/jwt.c
> +++ b/test/self/jwt.c
> @@ -97,8 +97,7 @@ static void test_jwt(void)
>  	 * noisy, so we decrease logging a bit during their run
>  	 */
>  
> -	old_loglevel = barebox_loglevel;
> -	barebox_loglevel = MSG_CRIT;
> +	old_loglevel = barebox_set_loglevel(MSG_CRIT);
>  
>  	jwt_rs256_mangled = strdup(jwt_rs256);
>  	ch = &jwt_rs256_mangled[strlen(jwt_rs256_mangled) - 1];
> @@ -152,6 +151,6 @@ static void test_jwt(void)
>  		jwt_free(jwt);
>  	}
>  
> -	barebox_loglevel = old_loglevel;
> +	barebox_set_loglevel(old_loglevel);
>  }
>  bselftest(parser, test_jwt);
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |