From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 22 Nov 2023 18:42:41 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r5rFI-004epI-1t for lore@lore.pengutronix.de; Wed, 22 Nov 2023 18:42:41 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5rFI-0002op-MA for lore@pengutronix.de; Wed, 22 Nov 2023 18:42:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GzsI90rPiJqlIhQQi/6d3gHFmRDrxF/IIEoX0ni7NLg=; b=dpHCIyGk3cBij+OhbuEtD3RUob a+1Q8XHAfoyYzR+i1VRdnwCOu70JbMeKidUJYj3dwa+TuxGWHXi0r+0WnB09TcY7E1kZCbtvBgCKk OKb5Z5HrO8YZy6vVpvf69tZShHLm0vR8wsakK81uVJSrZpNkXBdjaGqjcref5Qlnz4O/FByu1UG9x 9VH73ujTV1nvlsGywJRhBWcYiarJPI6Y2J1pYeWzuJHakzbNrBxFOqEBdEMygVgLfITlggpdz1ZZN SMSDF3kgD7kv9IBEf0igi9cW85admf8OqLJQ8GGTbmMiVXYVU9NsO1Sb6NbwkPN71Ri7gqTsIJNd3 IiwePFsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5rEB-002hmn-0O; Wed, 22 Nov 2023 17:41:31 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5rE2-002hgs-2U for barebox@lists.infradead.org; Wed, 22 Nov 2023 17:41:26 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r5rE1-0002Bh-Kw; Wed, 22 Nov 2023 18:41:21 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5rE1-00ArX8-8K; Wed, 22 Nov 2023 18:41:21 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1r5r34-001lAy-1X; Wed, 22 Nov 2023 18:30:02 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Wed, 22 Nov 2023 18:29:49 +0100 Message-Id: <20231122172951.376531-19-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231122172951.376531-1-a.fatoum@pengutronix.de> References: <20231122172951.376531-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_094122_811683_9AD90DC1 X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v2 18/20] of: constify string pointed to by struct of_device_id::compatible X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) In Linux struct of_device_id::compatible is a character array, but in barebox, so far it has been a pointer to char *. As most compatible strings are smaller than 24 bytes, we are likely saving some space by using a pointer, so we will keep that is, but let's make the member const to reflect the fact that it points at immutable strings and to allow easier use without casting. Signed-off-by: Ahmad Fatoum --- v1 -> v2: - new patch (Sascha) --- include/of.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/of.h b/include/of.h index 5686709fcf0a..e99b41ef6f14 100644 --- a/include/of.h +++ b/include/of.h @@ -40,7 +40,7 @@ struct device_node { }; struct of_device_id { - char *compatible; + const char *compatible; const void *data; }; -- 2.39.2