mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 4/7] ARM: stm32mp: don't re-enable DBGCFGR clock
Date: Wed, 22 Nov 2023 19:11:13 +0100	[thread overview]
Message-ID: <20231122181116.591131-5-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20231122181116.591131-1-a.fatoum@pengutronix.de>

TF-A will already enable the DBGMCU peripheral for us, so let's
skip setting the bit. This is useful, because while the peripheral's
base address stays the same between MP15 and MP13, the clock's offset
within the RCC peripheral doesn't, so by skipping the clock enablement,
we avoid having to differentiate between MP13 and MP15 that early.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/mach/stm32mp/revision.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/mach/stm32mp/revision.h b/include/mach/stm32mp/revision.h
index 63bdcb3a4dbb..47e2651432bc 100644
--- a/include/mach/stm32mp/revision.h
+++ b/include/mach/stm32mp/revision.h
@@ -64,9 +64,6 @@ int stm32mp_package(void);
 #define DBGMCU_IDC_REV_ID_MASK	GENMASK(31, 16)
 #define DBGMCU_IDC_REV_ID_SHIFT	16
 
-#define RCC_DBGCFGR		(STM32_RCC_BASE + 0x080C)
-#define RCC_DBGCFGR_DBGCKEN	BIT(8)
-
 /* BSEC OTP index */
 #define BSEC_OTP_RPN	1
 #define BSEC_OTP_PKG	16
@@ -77,7 +74,6 @@ int stm32mp_package(void);
 
 static inline u32 stm32mp_read_idc(void)
 {
-	setbits_le32(RCC_DBGCFGR, RCC_DBGCFGR_DBGCKEN);
 	return readl(IOMEM(DBGMCU_IDC));
 }
 
-- 
2.39.2




  parent reply	other threads:[~2023-11-22 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 18:11 [PATCH 0/7] ARM: stm32mp: random STM32MP13 fixes Ahmad Fatoum
2023-11-22 18:11 ` [PATCH 1/7] ARM: dts: stm32mp: stm32mp135-dk: drop duplicate property Ahmad Fatoum
2023-11-22 18:11 ` [PATCH 2/7] ARM: dts: stm32mp: fix model string for stm32mp135f-dk Ahmad Fatoum
2023-11-22 18:11 ` [PATCH 3/7] ARM: stm32mp: init: drop unused macros Ahmad Fatoum
2023-11-22 18:11 ` Ahmad Fatoum [this message]
2023-11-22 18:11 ` [PATCH 5/7] ARM: stm32mp: init: handle differences between STM32MP13 and STM32MP15 Ahmad Fatoum
2023-11-22 18:11 ` [PATCH 6/7] ARM: stm32mp: init: don't print STM32MP15 CPU type Ahmad Fatoum
2023-11-22 18:11 ` [PATCH 7/7] ARM: stm32mp: init: ignore of_register_fixup return value Ahmad Fatoum
2023-11-23  7:25 ` [PATCH 0/7] ARM: stm32mp: random STM32MP13 fixes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231122181116.591131-5-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox