mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! test: self: add JSON Web Token tests
Date: Thu, 23 Nov 2023 08:19:55 +0100	[thread overview]
Message-ID: <20231123071955.GC3359458@pengutronix.de> (raw)
In-Reply-To: <20231122155443.1446732-1-a.fatoum@pengutronix.de>

On Wed, Nov 22, 2023 at 04:54:43PM +0100, Ahmad Fatoum wrote:
> test: self: jwt: use barebox_set_loglevel
> 
> For CONFIG_CONSOLE_SIMPLE or CONFIG_CONSOLE_FULL, this is equivalent,
> but for CONFIG_CONSOLE_NONE, this fixes a linker error as
> barebox_loglevel isn't defined in that case.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>   - send as fixup instead of a patch as fixed commit is still in next
> ---
>  test/self/jwt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/test/self/jwt.c b/test/self/jwt.c
> index f37b44be22b8..015a0e436736 100644
> --- a/test/self/jwt.c
> +++ b/test/self/jwt.c
> @@ -97,8 +97,7 @@ static void test_jwt(void)
>  	 * noisy, so we decrease logging a bit during their run
>  	 */
>  
> -	old_loglevel = barebox_loglevel;
> -	barebox_loglevel = MSG_CRIT;
> +	old_loglevel = barebox_set_loglevel(MSG_CRIT);
>  
>  	jwt_rs256_mangled = strdup(jwt_rs256);
>  	ch = &jwt_rs256_mangled[strlen(jwt_rs256_mangled) - 1];
> @@ -152,6 +151,6 @@ static void test_jwt(void)
>  		jwt_free(jwt);
>  	}
>  
> -	barebox_loglevel = old_loglevel;
> +	barebox_set_loglevel(old_loglevel);
>  }
>  bselftest(parser, test_jwt);
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2023-11-23  7:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 15:54 Ahmad Fatoum
2023-11-23  7:19 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123071955.GC3359458@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox