From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] of: reserved-mem: add debug print for reservations
Date: Thu, 23 Nov 2023 08:23:10 +0100 [thread overview]
Message-ID: <20231123072310.GF3359458@pengutronix.de> (raw)
In-Reply-To: <20231122173118.569620-1-a.fatoum@pengutronix.de>
On Wed, Nov 22, 2023 at 06:31:18PM +0100, Ahmad Fatoum wrote:
> reserve_sdram_region can now involve cache maintenance, so add a debug
> print beforehand to aid debugging.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/of/reserved-mem.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/of/reserved-mem.c b/drivers/of/reserved-mem.c
> index f50a0bd8374d..599a7c968afd 100644
> --- a/drivers/of/reserved-mem.c
> +++ b/drivers/of/reserved-mem.c
> @@ -1,6 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-only
> // SPDX-FileCopyrightText: 2021 Rouven Czerwinski <r.czerwinski@pengutronix.de>, Pengutronix
>
> +#define pr_fmt(fmt) "of-reserved-mem: " fmt
> +
> #include <stdio.h>
> #include <of.h>
> #include <of_address.h>
> @@ -17,6 +19,8 @@ static void request_region(struct resource *r)
> if (!resource_contains(bank->res, r))
> continue;
>
> + pr_debug("reserving %s at %pad-%pad\n", r->name, &r->start, &r->end);
> +
> if (!reserve_sdram_region(r->name, r->start, resource_size(r)))
> pr_warn("couldn't request reserved sdram region %pa-%pa\n",
> &r->start, &r->end);
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-11-23 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 17:31 Ahmad Fatoum
2023-11-23 7:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123072310.GF3359458@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox