From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 29 Nov 2023 10:13:46 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r8Gdd-00D42D-3D for lore@lore.pengutronix.de; Wed, 29 Nov 2023 10:13:46 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8Gdd-00071R-W5 for lore@pengutronix.de; Wed, 29 Nov 2023 10:13:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:From:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vLsiFOHvZuNr6sQEuVXXM8MRjCnaOBf8vz1J31UpW/c=; b=nyG/O6sL4mYyl7U9EWgKHjrWdS Y/xYS6qlc7q6d8B4x4vqs6jWk+FSRYkzFjBfoN26YJl3NjEDp1QUASvhwC6LplBOhqtRrtMmJ/+ln 9Si5af2YyYKmL9hxK8cT198WIotz5QPLcNL5RNNtvSUkwMsHb3vFY/GaQxT5eTtFLVgXMyeTa9j+K 3IQUffnQ4/xW4Q4fmkkYD0bIpmQ238jxnRMo1FD0Ri658vwwq89m5mBpahaLMtsuyeMTxxYexVc9H u/whAF8dUhoYXkDqNuSOlyZx+UrXHcnw+XaLJ27uLiK0DWlrVNN+t/MioVPBA/in+lREiOqRZaeKb Jz/X0X4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8GcL-007aGW-2T; Wed, 29 Nov 2023 09:12:25 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8GcH-007aFt-2O for barebox@lists.infradead.org; Wed, 29 Nov 2023 09:12:23 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8GcF-0006se-LT; Wed, 29 Nov 2023 10:12:19 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r8GcF-00CN7y-91; Wed, 29 Nov 2023 10:12:19 +0100 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1r8GcF-004Plg-6Y; Wed, 29 Nov 2023 10:12:19 +0100 Date: Wed, 29 Nov 2023 10:12:19 +0100 To: Ahmad Fatoum Cc: barebox@lists.infradead.org Message-ID: <20231129091219.GK977968@pengutronix.de> References: <20231127063559.2205776-1-a.fatoum@pengutronix.de> <20231127063559.2205776-4-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127063559.2205776-4-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) From: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_011221_776863_3BE955FD X-CRM114-Status: GOOD ( 28.76 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 3/8] deep-probe: skip on-demand platform dev creation for nodes without compatible X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Mon, Nov 27, 2023 at 07:35:54AM +0100, Ahmad Fatoum wrote: > of_device_create_on_demand won't create a new device if the device tree > node already has a device associated. What it will do however, is to > create devices for all parent nodes in the device tree if they don't > already exist. This is unnecessary and clutters the device list > with nodes that won't ever be matched as they lack a compatible anyway. > For example a reference to scmi_reg11 in below snippet: > > &{scmi/protocol@17} { > reg = <0x17>; > regulators { > #address-cells = <0x1>; > #size-cells = <0x0>; > scmi_reg11: regulator@0 { > reg = <0x0>; > regulator-name = "reg11"; > }; > }; > }; > > will result in creation of a device for the regulators node that serves > no purpose whatsoever: > > `-- firmware.of > `-- firmware:scmi.of > `-- scmi_dev0 > `-- firmware:scmi:protocol@17:regulators.of > > Avoid this by creating devices on demand only if they have a compatible. How will this change affect the device hierarchy? When a parent device node doesn't have a compatible, will the child device then be a child of its grandparent, or will it just have no parent at all? Sascha > > Signed-off-by: Ahmad Fatoum > --- > drivers/of/platform.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 9e592d567cae..9ba4438812c1 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -442,9 +442,6 @@ static struct device *of_device_create_on_demand(struct device_node *np) > if (!np->dev && parent->dev) > device_rescan(parent->dev); > > - if (!np->dev) > - pr_debug("Creating device for %pOF\n", np); > - > /* Create all parent devices needed for the requested device */ > parent_dev = parent->dev ? : of_device_create_on_demand(parent); > if (IS_ERR(parent_dev)) > @@ -458,6 +455,11 @@ static struct device *of_device_create_on_demand(struct device_node *np) > if (np->dev) > return np->dev; > > + if (!of_property_present(np, "compatible")) > + return NULL; > + > + pr_debug("Creating device for %pOF\n", np); > + > if (of_device_is_compatible(np, "arm,primecell")) > dev = of_amba_device_create(np); > else > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |