mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v4 0/3] net: macb: fix dma usage
Date: Fri, 01 Dec 2023 14:51:26 +0100	[thread overview]
Message-ID: <20231201-v2023-08-0-topic-macb-v4-0-b4f5d64de1ad@pengutronix.de> (raw)

The rx_buffer is only dma_alloc'ed but never properly flushed.
Fix that.

While at it, also use proper volatile access instead of sw barriers.

Also, redefine PKTSIZE to a sensible multiple of 64 bytes.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Changes in v4:
- align PKTSIZE with cacheline size
- minor style changes
- Link to v3: https://lore.barebox.org/20231129-v2023-08-0-topic-macb-v3-0-65ad6db834dc@pengutronix.de

Changes in v3:
- fix dma_unmap_single direction
- dma_map_single packet in macb_send()
- Link to v2: https://lore.barebox.org/20231129-v2023-08-0-topic-macb-v2-0-4dc2cb4d5d25@pengutronix.de

Changes in v2:
- change dma_map_single to DMA_FROM_DEVICE
- drop (unsigned long) casts in dma_sync_*
- rework writel/setbits/clearbits to keep semantics
- Link to v1: https://lore.barebox.org/20231128-v2023-08-0-topic-macb-v1-0-9faff73bc990@pengutronix.de

---
Steffen Trumtrar (3):
      net: macb: fix dma_alloc for rx_buffer
      net: macb: convert to volatile accesses
      include: net: align PKTSIZE to 64 bytes

 drivers/net/macb.c | 132 +++++++++++++++++++++++++++++------------------------
 include/net.h      |   4 +-
 2 files changed, 75 insertions(+), 61 deletions(-)
---
base-commit: 5f200dd534c848dfa5d948334b6373f0310b8f73
change-id: 20231128-v2023-08-0-topic-macb-0c13ed91179d

Best regards,
-- 
Steffen Trumtrar <s.trumtrar@pengutronix.de>




             reply	other threads:[~2023-12-01 13:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 13:51 Steffen Trumtrar [this message]
2023-12-01 13:51 ` [PATCH v4 1/3] net: macb: fix dma_alloc for rx_buffer Steffen Trumtrar
2023-12-01 13:51 ` [PATCH v4 2/3] net: macb: convert to volatile accesses Steffen Trumtrar
2023-12-01 13:51 ` [PATCH v4 3/3] include: net: align PKTSIZE to 64 bytes Steffen Trumtrar
2023-12-05  8:04 ` [PATCH v4 0/3] net: macb: fix dma usage Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231201-v2023-08-0-topic-macb-v4-0-b4f5d64de1ad@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox