From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/6] cdev: export cdevfs_add_partition for general use
Date: Wed, 3 Jan 2024 11:16:26 +0100 [thread overview]
Message-ID: <20240103101629.2629497-4-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240103101629.2629497-1-a.fatoum@pengutronix.de>
__devfs_add_partition was added, so it can internally be used by
functions that already have a cdev and don't require looking it up first
by file path. This is useful elsewhere as well, so give it a less
internal-sounding name and start exporting it.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
fs/devfs-core.c | 6 +++---
include/driver.h | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/fs/devfs-core.c b/fs/devfs-core.c
index 6abf5eacc8dd..912bfeede8dc 100644
--- a/fs/devfs-core.c
+++ b/fs/devfs-core.c
@@ -474,7 +474,7 @@ static struct cdev *check_overlap(struct cdev *cdev, const char *name, loff_t of
return ret ? ERR_PTR(ret) : cpart;
}
-static struct cdev *__devfs_add_partition(struct cdev *cdev,
+struct cdev *cdevfs_add_partition(struct cdev *cdev,
const struct devfs_partition *partinfo, loff_t *end)
{
loff_t offset, size;
@@ -572,7 +572,7 @@ struct cdev *devfs_add_partition(const char *devname, loff_t offset,
if (!cdev)
return ERR_PTR(-ENOENT);
- return __devfs_add_partition(cdev, &partinfo, NULL);
+ return cdevfs_add_partition(cdev, &partinfo, NULL);
}
int devfs_del_partition(const char *name)
@@ -618,7 +618,7 @@ int devfs_create_partitions(const char *devname,
for (; partinfo->name; ++partinfo) {
struct cdev *new;
- new = __devfs_add_partition(cdev, partinfo, &offset);
+ new = cdevfs_add_partition(cdev, partinfo, &offset);
if (IS_ERR(new))
return PTR_ERR(new);
diff --git a/include/driver.h b/include/driver.h
index 0e3d5635e4c1..373c4f1d0bca 100644
--- a/include/driver.h
+++ b/include/driver.h
@@ -681,6 +681,9 @@ struct cdev *devfs_add_partition(const char *devname, loff_t offset,
loff_t size, unsigned int flags, const char *name);
int devfs_del_partition(const char *name);
+struct cdev *cdevfs_add_partition(struct cdev *cdev,
+ const struct devfs_partition *partinfo, loff_t *end);
+
#define of_match_ptr(compat) \
IS_ENABLED(CONFIG_OFDEVICE) ? (compat) : NULL
--
2.39.2
next prev parent reply other threads:[~2024-01-03 10:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 10:16 [PATCH 0/6] cdev: delete partitions when deleting master cdev Ahmad Fatoum
2024-01-03 10:16 ` [PATCH 1/6] cdev: make __devfs_add_partition's last argument optional Ahmad Fatoum
2024-01-03 10:16 ` [PATCH 2/6] driver.h: move devfs_add/del_partition later in file Ahmad Fatoum
2024-01-03 10:16 ` Ahmad Fatoum [this message]
2024-01-04 8:22 ` [PATCH 3/6] cdev: export cdevfs_add_partition for general use Sascha Hauer
2024-01-04 8:51 ` [PATCH] fixup! " Ahmad Fatoum
2024-01-03 10:16 ` [PATCH 4/6] partition: switch to using cdevfs_add_partition Ahmad Fatoum
2024-01-03 10:16 ` [PATCH 5/6] cdev: export and use cdevfs_del_partition Ahmad Fatoum
2024-01-03 10:16 ` [PATCH 6/6] cdev: delete partitions when deleting master cdev Ahmad Fatoum
2024-01-08 9:59 ` [PATCH 0/6] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240103101629.2629497-4-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox