From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 19 Jan 2024 17:43:20 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rQrxf-007HXk-1U for lore@lore.pengutronix.de; Fri, 19 Jan 2024 17:43:20 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQrxg-0005Ql-6e for lore@pengutronix.de; Fri, 19 Jan 2024 17:43:20 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kTHFJxGVlxImWkcxJW2nQR2f7N/m+cWQosHuXXKFm/4=; b=H4kEOCkNM4PrhMTnllKC4k0pD5 gqQPWdWwDt0OS9R3xlgS35LB5fX+l03NrCbfczNnCTWJgqF6Film8/3eX3OnvAHd7NXpjIRTYNAEr 3CRIkL3JQdQ+cpBeEkC5+gd41Kov/e7EvLQFoAjGS2wULyexI91U1GfXYtai2JvrCn81/x8jTd5BH sptmceeIy9DMSPZkY9UY6QP/5jH1y4biisIzTsCQoJqzcf3N42aBU2reaRP11NvwExD6HDYKVIL11 506OBiOn9SgTupvFPDzUOMgd5Fw74LT0BkBOe1S0l9D0IGYtyje5KXiUBgcfas8MPlet8YIyTQtNr zi01VKxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQrwk-0069g8-0y; Fri, 19 Jan 2024 16:42:22 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQrwc-0069Zw-0z for barebox@lists.infradead.org; Fri, 19 Jan 2024 16:42:17 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQrwb-0004yq-6S; Fri, 19 Jan 2024 17:42:13 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rQrwa-000xYg-Q3; Fri, 19 Jan 2024 17:42:12 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rQrh8-0054dX-2D; Fri, 19 Jan 2024 17:26:14 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 19 Jan 2024 17:26:04 +0100 Message-Id: <20240119162610.1014870-14-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240119162610.1014870-1-a.fatoum@pengutronix.de> References: <20240119162610.1014870-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_084214_350771_6394A2E2 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 13/19] driver: have dev_request_mem_region_err_null warn if resource starts at 0 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) dev_request_mem_region_err_null() is used very scarcely, because it doesn't allow differentiating between NULL and a MMIO region at address 0. Using it in the latter case is always a bug, so add a WARN_ON that warns about this. This should make it safe to use at more places, which will come in handy to implement Linux API that uses NULL as error value. Signed-off-by: Ahmad Fatoum --- drivers/base/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/driver.c b/drivers/base/driver.c index 4f18f5bb8123..6548aec9b27b 100644 --- a/drivers/base/driver.c +++ b/drivers/base/driver.c @@ -541,7 +541,7 @@ void __iomem *dev_request_mem_region_err_null(struct device *dev, int num) struct resource *res; res = dev_request_mem_resource(dev, num); - if (IS_ERR(res)) + if (IS_ERR(res) || WARN_ON(!res->start)) return NULL; return IOMEM(res->start); -- 2.39.2