mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug
@ 2024-02-13 10:01 Ahmad Fatoum
  2024-02-13 10:01 ` [PATCH 2/3] mci: atmel_mci: " Ahmad Fatoum
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2024-02-13 10:01 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The IP version won't change from one boot to the next, so it's not
useful to print this every time. Lower it to debug level instead.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/spi/atmel_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/atmel_spi.c b/drivers/spi/atmel_spi.c
index 5c42ff2e89c5..90f655dc3ecb 100644
--- a/drivers/spi/atmel_spi.c
+++ b/drivers/spi/atmel_spi.c
@@ -378,7 +378,7 @@ static void atmel_get_caps(struct atmel_spi *as)
 	unsigned int version;
 
 	version = atmel_get_version(as);
-	dev_info(as->master.dev, "version: 0x%x\n", version);
+	dev_dbg(as->master.dev, "version: 0x%x\n", version);
 
 	as->caps.is_spi2 = version > 0x121;
 }
-- 
2.39.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] mci: atmel_mci: lower version log output from info to debug
  2024-02-13 10:01 [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Ahmad Fatoum
@ 2024-02-13 10:01 ` Ahmad Fatoum
  2024-02-13 10:01 ` [PATCH 3/3] mci: atmel_mci: mark atmci_setup_data very verbose debug print Ahmad Fatoum
  2024-02-16 11:56 ` [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2024-02-13 10:01 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The IP version won't change from one boot to the next, so it's not
useful to print this every time. Lower it to debug level instead.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/atmel_mci_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/atmel_mci_common.c b/drivers/mci/atmel_mci_common.c
index ec710f1cfc38..68110c04b096 100644
--- a/drivers/mci/atmel_mci_common.c
+++ b/drivers/mci/atmel_mci_common.c
@@ -437,7 +437,7 @@ void atmci_get_cap(struct atmel_mci *host)
 	version = atmci_readl(host, ATMCI_VERSION) & 0x00000fff;
 	host->version = version;
 
-	dev_info(host->hw_dev, "version: 0x%x\n", version);
+	dev_dbg(host->hw_dev, "version: 0x%x\n", version);
 
 	host->caps.has_cfg_reg = 0;
 	host->caps.has_highspeed = 0;
-- 
2.39.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] mci: atmel_mci: mark atmci_setup_data very verbose debug print
  2024-02-13 10:01 [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Ahmad Fatoum
  2024-02-13 10:01 ` [PATCH 2/3] mci: atmel_mci: " Ahmad Fatoum
@ 2024-02-13 10:01 ` Ahmad Fatoum
  2024-02-16 11:56 ` [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2024-02-13 10:01 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

setup_data is called prior to every transfer and will print the number
of blocks and the block size. With CONFIG_DEBUG_PBL it will be enabled,
but doesn't really add much information. Lower it to verbose debug level
instead.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/atmel_mci_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/atmel_mci_common.c b/drivers/mci/atmel_mci_common.c
index 68110c04b096..098e90503a3a 100644
--- a/drivers/mci/atmel_mci_common.c
+++ b/drivers/mci/atmel_mci_common.c
@@ -220,7 +220,7 @@ static void atmci_setup_data(struct atmel_mci *host, struct mci_data *data)
 
 	host->data = data;
 
-	dev_dbg(host->hw_dev, "atmel_setup_data: nob=%d blksz=%d\n",
+	dev_vdbg(host->hw_dev, "atmel_setup_data: nob=%d blksz=%d\n",
 		nob, blksz);
 
 	atmci_writel(host, ATMCI_BLKR, ATMCI_BCNT(nob)
-- 
2.39.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug
  2024-02-13 10:01 [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Ahmad Fatoum
  2024-02-13 10:01 ` [PATCH 2/3] mci: atmel_mci: " Ahmad Fatoum
  2024-02-13 10:01 ` [PATCH 3/3] mci: atmel_mci: mark atmci_setup_data very verbose debug print Ahmad Fatoum
@ 2024-02-16 11:56 ` Sascha Hauer
  2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2024-02-16 11:56 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 13 Feb 2024 11:01:44 +0100, Ahmad Fatoum wrote:
> The IP version won't change from one boot to the next, so it's not
> useful to print this every time. Lower it to debug level instead.
> 
> 

Applied, thanks!

[1/3] spi: atmel_spi: lower version log output from info to debug
      https://git.pengutronix.de/cgit/barebox/commit/?id=f2fcaf2992e8 (link may not be stable)
[2/3] mci: atmel_mci: lower version log output from info to debug
      https://git.pengutronix.de/cgit/barebox/commit/?id=ab420f54b470 (link may not be stable)
[3/3] mci: atmel_mci: mark atmci_setup_data very verbose debug print
      https://git.pengutronix.de/cgit/barebox/commit/?id=e90bf7a1c54b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-16 11:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 10:01 [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Ahmad Fatoum
2024-02-13 10:01 ` [PATCH 2/3] mci: atmel_mci: " Ahmad Fatoum
2024-02-13 10:01 ` [PATCH 3/3] mci: atmel_mci: mark atmci_setup_data very verbose debug print Ahmad Fatoum
2024-02-16 11:56 ` [PATCH 1/3] spi: atmel_spi: lower version log output from info to debug Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox