mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] fixup! common: add TQ EEPROM support
Date: Tue, 13 Feb 2024 14:47:38 +0100	[thread overview]
Message-ID: <20240213134738.3092799-1-s.hauer@pengutronix.de> (raw)

&eeprom.vard is not yet initialized, use &raw.tq_hw_data instead which
we have just read from the EEPROM.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/boards/tq/tq_eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/boards/tq/tq_eeprom.c b/common/boards/tq/tq_eeprom.c
index edc57b01f5..220d75ecab 100644
--- a/common/boards/tq/tq_eeprom.c
+++ b/common/boards/tq/tq_eeprom.c
@@ -128,7 +128,7 @@ struct tq_eeprom *pbl_tq_read_eeprom(struct pbl_i2c *i2c, u8 addr)
 	if (ret)
 		return NULL;
 
-	if (tq_vard_valid(&eeprom.vard))
+	if (tq_vard_valid(&raw.tq_hw_data.vard))
 		eeprom.vard = raw.tq_hw_data.vard;
 
 	memcpy(eeprom.mac, raw.mac, TQ_EE_MAC_BYTES);
-- 
2.39.2




                 reply	other threads:[~2024-02-13 13:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213134738.3092799-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox