From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 16 Feb 2024 23:04:31 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rb6Jr-0094KY-2P for lore@lore.pengutronix.de; Fri, 16 Feb 2024 23:04:31 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rb6Jr-0006Qf-6c for lore@pengutronix.de; Fri, 16 Feb 2024 23:04:31 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=q9wJEvLbMCWMIJQ+GnIsccPFH2JKlpGqJrvUsN6aaNI=; b=LgE+xswqJIEF5DL5Ls5lUVY7nd mu8rGnh4lvVzhZGJmNe7/V60TCmJZkca5838gBI8e2bD1I9N6a1uh8t89SbPMmCn4RRrU+umHL2km IuRB9VkVSxzjNgfZWUFr/MfCp3Bsu9RfXPuuw1d/IXbbdrKoWNMbTC5p5MA5HeSMI71pFsVG2axDN 1d6L5wtDjHKSdqQhuy51gPPB4aMqd+ikFyK5dhSA10hOj8G+HePHTAxyxu7LAYiXw9IeXfvS2FrEo tSGlONuDfwqsXRyuQNTV5rasF3BCpDjCrDMK1MnQtNXqUgtoTj+h6CLZK0j1uTAWdPCJm0SoFAios svIvSfCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb6JA-00000003sIP-05f3; Fri, 16 Feb 2024 22:03:48 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rb6J6-00000003sHR-1cba for barebox@lists.infradead.org; Fri, 16 Feb 2024 22:03:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rb6J0-0006NI-PN; Fri, 16 Feb 2024 23:03:38 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rb6J0-0019Fp-Cs; Fri, 16 Feb 2024 23:03:38 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rb6J0-009lON-10; Fri, 16 Feb 2024 23:03:38 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 16 Feb 2024 23:03:37 +0100 Message-Id: <20240216220337.2327115-1-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_140344_445695_46EEDD5F X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH master] i2c: don't return error pointers from of_find_i2c_adapter_by_node X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) All callers of of_find_i2c_adapter_by_node expect errors to be indicated by NULL and don't check non-NULL pointers with IS_ERR(). Therefore map of_device_ensure_probed() errors to NULL as well to avoid dereferencing error pointers. Signed-off-by: Ahmad Fatoum --- drivers/i2c/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c.c b/drivers/i2c/i2c.c index 70d1b810c1c3..1985ddfdc776 100644 --- a/drivers/i2c/i2c.c +++ b/drivers/i2c/i2c.c @@ -593,7 +593,7 @@ struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node) ret = of_device_ensure_probed(node); if (ret) - return ERR_PTR(ret); + return NULL; for_each_i2c_adapter(adap) if (adap->dev.of_node == node) -- 2.39.2