From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 20 Feb 2024 10:32:02 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rcMTq-00Fqgx-0K for lore@lore.pengutronix.de; Tue, 20 Feb 2024 10:32:02 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcMTl-0002ia-Su for lore@pengutronix.de; Tue, 20 Feb 2024 10:32:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+brBqewzZCIWPgeCsQ9IvlLu4ZfYWjw7wC2iQsbA8Fc=; b=0R46fgHcqNPgGKltz2Ir3NbmNy jks5+OqfrtDoxrRxd46S8gdOGoGXqIVC4T3nTKPqPsaC8zEE5Hv66JhW4RSkd1DktyGZgglZxm2hK qgdG2k+yyfbN0Gb0NfQJfEOiWiUWwYYKABSRVY5P/O6al2K44aAL36PTLnmJtl//EawINA1/3Qzzb PYO6kLH0NRflZFoXAFyxUqQp422mjXWr004QbwZ0JvybJ0XtiawQ6V2tSdqCsN7LCUkFBg7Ut/2Pc EE6wN35Bc+Ih47idgJxu79Kv/gdSr7JCbdJ+IpMkr8Ikg+21YzctCfZ8ZN0aEQlIwths+xrNQL4MH v6uSrkSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMT9-0000000Dzus-2N6Q; Tue, 20 Feb 2024 09:31:19 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMT0-0000000Dzo9-04GZ for barebox@lists.infradead.org; Tue, 20 Feb 2024 09:31:13 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcMSy-0002F6-Om; Tue, 20 Feb 2024 10:31:08 +0100 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcMSy-001oi2-BU; Tue, 20 Feb 2024 10:31:08 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rcMSy-006TH7-0r; Tue, 20 Feb 2024 10:31:08 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Sam Ravnborg , Ahmad Fatoum Date: Tue, 20 Feb 2024 10:30:52 +0100 Message-Id: <20240220093100.1539120-7-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240220093100.1539120-1-a.fatoum@pengutronix.de> References: <20240220093100.1539120-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_013110_190713_07D28882 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v4 06/14] ARM: at91: sam9263_ll: drop PLL charge pump initialization X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The datasheet[1] described the PLL Charge Pump Current Register in 27.9.17 very sparingly by mandating that 0x10001 is to be written into it. In the 28-Jan-16 revision of the datasheet the access mode for the register was changed from Write-only to Read/Write. Indeed reading the register is possible, but it seems to always return 0, even directly after write. Given that code for initializing the PLL charge pumps was added to AT91Bootsrap only for SAMA5 support and that apparently no adverse effect was observed on SAM9263 for not doing this for all these years, it follows that the PLL charge pump has to be already initialized on POR or by BootROM and we are better off playing it safe and not introducing code in the PMC setup that didn't exist in Atmel's own AT91Bootstrap. Therefore drop that line again. There are no upstream boards calling this function yet anyway, so this should have very limited effect. [1]: Atmel-6249N-ATARM-SAM9263-Datasheet_14-Mar-16 Reviewed-by: Sam Ravnborg Signed-off-by: Ahmad Fatoum --- arch/arm/mach-at91/sam9263_ll.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-at91/sam9263_ll.c b/arch/arm/mach-at91/sam9263_ll.c index 8855a679fdf2..7600391629af 100644 --- a/arch/arm/mach-at91/sam9263_ll.c +++ b/arch/arm/mach-at91/sam9263_ll.c @@ -11,9 +11,6 @@ static void sam9263_pmc_init(const struct sam92_pmc_config *config) { at91_pmc_init(IOMEM(AT91SAM926X_BASE_PMC), 0); - /* Initialize PLL charge pump, must be done before PLLAR/PLLBR */ - at91_pmc_init_pll(IOMEM(AT91SAM926X_BASE_PMC), AT91SAM9_PMC_ICPPLLA | AT91SAM9_PMC_ICPPLLB); - /* Setting PLL A and divider A */ at91_pmc_cfg_plla(IOMEM(AT91SAM926X_BASE_PMC), AT91_PMC_MUL_(config->mula) | -- 2.39.2