Re: [PATCH] net: drop unused rarp.h

[Antony Pavlov <antonynpavlov@gmail.com>]

On Tue, 27 Feb 2024 10:39:23 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:

Hi All!

Actually there are much more unused header files:

    $ git clone https://github.com/barebox/barebox
    $ cd barebox
    barebox$ for i in $(git grep -h "#.*include" | sed "s/ //g" | grep "^#include" | sed "s/^#include[\"<]//g" | sed "s/[>\"]$//g" | sort | uniq); do basename $i; done | sort | uniq > /tmp/list1
    barebox$ for i in $(find -iname '*.h'); do basename $i; done | sort | uniq > /tmp/list2


Show unused header files:

    barebox$ for i in $(comm -13 /tmp/list1 /tmp/list2); do find -iname $i -type f ; done | grep -v ^./dts/ | sort

./arch/arm/boards/phytec-phycard-omap3/pca-a-l1.h
./arch/arm/include/asm/arch-check.h
./arch/powerpc/include/asm/pci_io.h
./arch/powerpc/include/asm/status_led.h
./arch/x86/include/asm/modes.h
./arch/x86/include/asm/segment.h
./drivers/mtd/nand/atmel/atmel_nand_ecc.h
./drivers/usb/host/ehci-core.h
./fs/fat/ffconf.h
./include/gpiod.h
./include/linux/mtd/ndfc.h
./include/linux/mtd/nftl.h
./include/linux/usb/usbroothubdes.h
./include/mach/imx/ccm.h
./include/mach/imx/devices-imx21.h
./include/mach/imx/devices-imx31.h
./include/mach/imx/devices-imx35.h
./include/mach/imx/devices-imx50.h
./include/mach/imx/habv3-imx25-gencsf.h
./include/mach/imx/iomux-mx21.h
./include/mach/imx/iomux-mx35.h
./include/mach/imx/iomux-mx50.h
./include/mach/omap/intc.h
./include/usb_dfu_trailer.h
./lib/bzlib_private.h
./lib/zstd/zstd_opt.h
./net/nfs.h
./net/rarp.h


Check for false positives:

    barebox$ for i in $(comm -13 /tmp/list1 /tmp/list2); do git grep $i ; done  | grep -v ^dts\/ | grep "#include"

drivers/mtd/nand/atmel/legacy.c:#include "atmel_nand_ecc.h"	/* Hardware ECC registers */
fs/fat/ff.h:#include "ffconf.h"	/* FatFs configuration options */
arch/arm/boards/phytec-phycore-pxa270/lowlevel_init.S:#include <mach/pxa/regs-intc.h>



> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  net/rarp.h | 23 -----------------------
>  1 file changed, 23 deletions(-)
> 
> diff --git a/net/rarp.h b/net/rarp.h
> deleted file mode 100644
> index 0986b02513f..00000000000
> --- a/net/rarp.h
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/* SPDX-FileCopyrightText: 2000 Wolfgang Denk <wd@denx.de>, DENX Software Engineering */
> -
> -#ifndef __RARP_H__
> -#define __RARP_H__
> -
> -#ifndef __NET_H__
> -#include <net.h>
> -#endif /* __NET_H__ */
> -
> -
> -/**********************************************************************/
> -/*
> - *	Global functions and variables.
> - */
> -
> -extern int	RarpTry;
> -
> -extern void RarpRequest (void);	/* Send a RARP request */
> -
> -/**********************************************************************/
> -
> -#endif /* __RARP_H__ */
> -- 
> 2.39.0
> 


-- 
Best regards,
  Antony Pavlov