From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 16 May 2024 09:09:13 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s7VEn-00GuTO-33 for lore@lore.pengutronix.de; Thu, 16 May 2024 09:09:13 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7VEl-0006T1-ME for lore@pengutronix.de; Thu, 16 May 2024 09:09:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To: Cc:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zAYTdERhgHodjppt0PRtk4pRWJnSP3DPFVNBjM3kT/Q=; b=4JaZ5aN0i+nGv4/GBg3mJE0Ftt nlWhg7ELBUyzLJjoADKhQ1Up8O1ES5U5Aq+aET/xwVV5KQdiU6gnE4iBgDRCQ0f9kO9Vp72GB4r59 uwRzmeTRkWuGWGjQKUKN7c/PsByBXry5sUCxkFe58LaMhWcqt88FRLS/npTx+9yyMsUU1UQC9cBE0 Kwb+LT29fbChDWajKkWFIQfz2aIp4g9tTHrIea22VKrfyvYU8adoRucUn4TSamlg+bHVz4JDn4zLm 7bMhzCCCNJ6Ke9c6X5nEx9LC2zDSnjImHtnQGBwors4xDJMKCundoRyHSSFUfVI4y78ZjLw/+8k+0 +GljfEow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7VEE-00000003wQx-01la; Thu, 16 May 2024 07:08:38 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7VE4-00000003wLc-0gou for barebox@lists.infradead.org; Thu, 16 May 2024 07:08:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7VDz-00061q-Td; Thu, 16 May 2024 09:08:23 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7VDz-001fT1-H5; Thu, 16 May 2024 09:08:23 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1s7VDz-00BWfZ-1N; Thu, 16 May 2024 09:08:23 +0200 From: Sascha Hauer To: Barebox List Date: Thu, 16 May 2024 09:08:17 +0200 Message-Id: <20240516070822.2746845-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240516070822.2746845-1-s.hauer@pengutronix.de> References: <20240516070822.2746845-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240516_000828_379142_791F3836 X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 2/7] ARM: tx28: use cdev_open_by_name() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) cdev_by_name() returns a cdev without increasing its reference count. In order to maintain a proper reference counting use cdev_open_by_name() instead and make sure it's closed afterwards when no longer needed. Signed-off-by: Sascha Hauer --- arch/arm/boards/karo-tx28/tx28-stk5.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/arm/boards/karo-tx28/tx28-stk5.c b/arch/arm/boards/karo-tx28/tx28-stk5.c index d1fd526c00..01a14a33a3 100644 --- a/arch/arm/boards/karo-tx28/tx28-stk5.c +++ b/arch/arm/boards/karo-tx28/tx28-stk5.c @@ -310,20 +310,21 @@ static const uint32_t tx28_starterkit_pad_setup[] = { */ static int register_persistent_environment(void) { - struct cdev *cdev; + struct cdev *cdev, *env; /* * The TX28 STK5 has only one usable MCI card socket. * So, we expect its name as "disk0". */ - cdev = cdev_by_name("disk0"); + cdev = cdev_open_by_name("disk0", O_RDONLY); if (cdev == NULL) { pr_err("No MCI card preset\n"); return -ENODEV; } + cdev_close(cdev); /* MCI card is present, also a usable partition on it? */ - cdev = cdev_by_name("disk0.1"); + cdev = cdev_open_by_name("disk0.1", O_RDONLY); if (cdev == NULL) { pr_err("No second partition available\n"); pr_info("Please create at least a second partition with" @@ -332,9 +333,11 @@ static int register_persistent_environment(void) } /* use the full partition as our persistent environment storage */ - cdev = devfs_add_partition("disk0.1", 0, cdev->size, + env = devfs_add_partition("disk0.1", 0, cdev->size, DEVFS_PARTITION_FIXED, "env0"); - return PTR_ERR_OR_ZERO(cdev); + cdev_close(cdev); + + return PTR_ERR_OR_ZERO(env); } static void tx28_get_ethaddr(void) -- 2.39.2