mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] images: sha_sum: mark as not needing executable stack
@ 2024-05-17  7:47 Ahmad Fatoum
  2024-05-17  7:47 ` [PATCH 2/2] x86: lib: setjmp: " Ahmad Fatoum
  2024-05-21  6:35 ` [PATCH 1/2] images: sha_sum: " Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-05-17  7:47 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The hash section contains only data, so add a note that an executable
stack is not needed. This will suppress a warning when we start using
this on sandbox.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 images/sha_sum.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/images/sha_sum.S b/images/sha_sum.S
index 5928c206a877..d62af87f6695 100644
--- a/images/sha_sum.S
+++ b/images/sha_sum.S
@@ -1,4 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
+
+        .section .note.GNU-stack,"",%progbits
         .section .shasum,"a"
         .globl  sha_sum
 sha_sum:
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] x86: lib: setjmp: mark as not needing executable stack
  2024-05-17  7:47 [PATCH 1/2] images: sha_sum: mark as not needing executable stack Ahmad Fatoum
@ 2024-05-17  7:47 ` Ahmad Fatoum
  2024-05-21  6:35 ` [PATCH 1/2] images: sha_sum: " Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-05-17  7:47 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

We don't require an executable stack for our x86 setjmp
implementations. Note that, so we don't get a warning when we start
using this implementation for sandbox when compiled on x86.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/x86/lib/setjmp_32.S | 2 ++
 arch/x86/lib/setjmp_64.S | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/x86/lib/setjmp_32.S b/arch/x86/lib/setjmp_32.S
index 5814623f9478..cf340d35d8fd 100644
--- a/arch/x86/lib/setjmp_32.S
+++ b/arch/x86/lib/setjmp_32.S
@@ -10,6 +10,8 @@
 #include <linux/linkage.h>
 #include <asm-generic/pointer.h>
 
+.section .note.GNU-stack,"",%progbits
+
 .text
 .align 8
 
diff --git a/arch/x86/lib/setjmp_64.S b/arch/x86/lib/setjmp_64.S
index bfa152149975..a0be4c0d7858 100644
--- a/arch/x86/lib/setjmp_64.S
+++ b/arch/x86/lib/setjmp_64.S
@@ -8,6 +8,8 @@
 #include <linux/linkage.h>
 #include <asm-generic/pointer.h>
 
+.section .note.GNU-stack,"",%progbits
+
 .text
 .align 8
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] images: sha_sum: mark as not needing executable stack
  2024-05-17  7:47 [PATCH 1/2] images: sha_sum: mark as not needing executable stack Ahmad Fatoum
  2024-05-17  7:47 ` [PATCH 2/2] x86: lib: setjmp: " Ahmad Fatoum
@ 2024-05-21  6:35 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-05-21  6:35 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Fri, 17 May 2024 09:47:53 +0200, Ahmad Fatoum wrote:
> The hash section contains only data, so add a note that an executable
> stack is not needed. This will suppress a warning when we start using
> this on sandbox.
> 
> 

Applied, thanks!

[1/2] images: sha_sum: mark as not needing executable stack
      https://git.pengutronix.de/cgit/barebox/commit/?id=320b72bfc91b (link may not be stable)
[2/2] x86: lib: setjmp: mark as not needing executable stack
      https://git.pengutronix.de/cgit/barebox/commit/?id=628e7d6e5d1c (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-21  6:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-17  7:47 [PATCH 1/2] images: sha_sum: mark as not needing executable stack Ahmad Fatoum
2024-05-17  7:47 ` [PATCH 2/2] x86: lib: setjmp: " Ahmad Fatoum
2024-05-21  6:35 ` [PATCH 1/2] images: sha_sum: " Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox