mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/7] test: self: digest: don't leak digest buffers
Date: Fri, 17 May 2024 09:48:20 +0200	[thread overview]
Message-ID: <20240517074824.767767-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240517074824.767767-1-a.fatoum@pengutronix.de>

The selftest leaks memory by letting the pointers go out of scope.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 test/self/digest.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/self/digest.c b/test/self/digest.c
index 4cda5b09637b..32815c85ba70 100644
--- a/test/self/digest.c
+++ b/test/self/digest.c
@@ -47,7 +47,7 @@ static void __test_digest(bool option,
 			  const char *algo, struct digest_test_case *t,
 			  const char *func, int line)
 {
-	unsigned char *output, *digest;
+	unsigned char *output = NULL, *digest = NULL;
 	struct digest *d;
 	int hash_len, digest_len;
 	u64 start;
@@ -103,8 +103,14 @@ static void __test_digest(bool option,
 		goto fail;
 	}
 
+	digest_free(d);
+	free(digest);
+	free(output);
 	return;
 fail:
+	digest_free(d);
+	free(digest);
+	free(output);
 	failed_tests++;
 }
 
-- 
2.39.2




  parent reply	other threads:[~2024-05-17  7:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17  7:48 [PATCH 1/7] of: free unflattened overlays after application Ahmad Fatoum
2024-05-17  7:48 ` [PATCH 2/7] of: overlay: do not leak fixed up path Ahmad Fatoum
2024-05-17  7:48 ` Ahmad Fatoum [this message]
2024-05-17  7:48 ` [PATCH 4/7] test: self: ramfs: fix memory leak Ahmad Fatoum
2024-05-17  7:48 ` [PATCH 5/7] regulator: of_regulator: remove unused allocation Ahmad Fatoum
2024-05-21  6:30   ` Sascha Hauer
2024-05-17  7:48 ` [PATCH 6/7] globalvar: fix memory leak Ahmad Fatoum
2024-05-17  7:48 ` [PATCH 7/7] power: reset: reboot-mode: " Ahmad Fatoum
2024-05-21  6:29 ` [PATCH 1/7] of: free unflattened overlays after application Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240517074824.767767-3-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox