From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 28 May 2024 10:58:55 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sBsfX-000sjh-2g for lore@lore.pengutronix.de; Tue, 28 May 2024 10:58:55 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBsfW-0001Hc-Pp for lore@pengutronix.de; Tue, 28 May 2024 10:58:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id:Date :Subject:To:From:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y0YhmGIdv7A1Sp3O0t8syT4xZEeShNQXNSCB7P8ESd0=; b=bx5laF8svHtnee GlgpoJOuf93Pj+i9dVSII3GLuupAsoZiP+PF8lqWrvDUuAsxGt6PLyyZ9YyC4nJNg/vvVuMrJraCa dtsbJl1VxVvUQeUOT1JS2vwBfWupWi+BH+LPQ/It+Lkzmyll6Du7KDSiBH9SrZrPTBufIh58vbitc 62zyinYqOl8/Pb3Us5WnuwfKfm4UCLgpl6/7B/MEQXKLlab2Ym7p9ICiMAbS5RtbuH7HTI+ysXRjS Yt8TrrE9qFBZyzbif1MQCtgbMX0C6DA7p33HtKjsxD1z33Rt3TLumSwzRy2z6v4Aa7LlQNPsZToG/ lyG/RWE/Nl7DGaCaayig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBsez-0000000HYlo-1snW; Tue, 28 May 2024 08:58:21 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBsep-0000000HYgs-3k9L for barebox@lists.infradead.org; Tue, 28 May 2024 08:58:15 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBsem-0000qM-PL; Tue, 28 May 2024 10:58:08 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBsem-003IsO-C6; Tue, 28 May 2024 10:58:08 +0200 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1sBsem-004v4p-0q; Tue, 28 May 2024 10:58:08 +0200 From: Sascha Hauer To: Barebox List Date: Tue, 28 May 2024 10:58:02 +0200 Message-Id: <20240528085806.1172689-6-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240528085806.1172689-1-s.hauer@pengutronix.de> References: <20240528085806.1172689-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_015812_124480_AF4E3A68 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jianqiang wang Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH v3 5/9] net: liteeth: do not set len to 0 before printing it X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) 'len' is set to 0 before it is printed, so printing it doesn't give any information. Drop this and print the erroneous len instead. Also, do not initialize 'len' initially as this initialization value is never used. Signed-off-by: Sascha Hauer --- drivers/net/liteeth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/liteeth.c b/drivers/net/liteeth.c index 0d63e1da16..f8a3ed4a59 100644 --- a/drivers/net/liteeth.c +++ b/drivers/net/liteeth.c @@ -214,7 +214,7 @@ static int liteeth_eth_rx(struct eth_device *edev) { struct liteeth *priv = edev->priv; u8 rx_slot; - int len = 0; + int len; u8 reg; reg = litex_read8(priv->base + LITEETH_WRITER_EV_PENDING); @@ -224,7 +224,6 @@ static int liteeth_eth_rx(struct eth_device *edev) len = litex_read32(priv->base + LITEETH_WRITER_LENGTH); if (len == 0 || len > PKTSIZE) { - len = 0; dev_err(priv->dev, "%s: invalid len %d\n", __func__, len); litex_write8(priv->base + LITEETH_WRITER_EV_PENDING, reg); goto done; -- 2.39.2