mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Cc: jianqiang wang <wjq.sec@gmail.com>
Subject: [PATCH v3 8/9] net: ks8851_mll: drop return value from ks8851_rx_frame()
Date: Tue, 28 May 2024 10:58:05 +0200	[thread overview]
Message-ID: <20240528085806.1172689-9-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240528085806.1172689-1-s.hauer@pengutronix.de>

The return value of ks8851_rx_frame() is unused, so let it return void.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/net/ks8851_mll.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ks8851_mll.c b/drivers/net/ks8851_mll.c
index 936191597a..4e2a05158e 100644
--- a/drivers/net/ks8851_mll.c
+++ b/drivers/net/ks8851_mll.c
@@ -672,7 +672,7 @@ static void ks_setup(struct ks_net *ks)
 	ks_wrreg16(ks, KS_RXCR1, w);
 }  /*ks_setup */
 
-static int ks8851_rx_frame(struct ks_net *ks)
+static void ks8851_rx_frame(struct ks_net *ks)
 {
 	struct device *dev = &ks->edev.dev;
 	u16 RxStatus, RxLen = 0;
@@ -726,9 +726,9 @@ static int ks8851_rx_frame(struct ks_net *ks)
 			dev_dbg(dev, "frame too long\n");
 		if (RxStatus & RXFSHR_RXMR)
 			dev_dbg(dev, "MII symbol error\n");
-	} else
+	} else {
 		dev_err(dev, "other RxStatus error 0x%04x\n", RxStatus);
-	return 0;
+	}
 }
 
 static int ks8851_eth_rx(struct eth_device *edev)
-- 
2.39.2




  parent reply	other threads:[~2024-05-28  8:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28  8:57 [PATCH v3 0/9] net: do not read past receive buffer Sascha Hauer
2024-05-28  8:57 ` [PATCH v3 1/9] net: cs8900: simplify buffer read loop Sascha Hauer
2024-05-28  8:57 ` [PATCH v3 2/9] net: cs8900: do not read past the receive buffer Sascha Hauer
2024-05-28  8:58 ` [PATCH v3 3/9] net: ks8851_mll: " Sascha Hauer
2024-05-28  8:58 ` [PATCH v3 4/9] net: liteeth: " Sascha Hauer
2024-05-28  8:58 ` [PATCH v3 5/9] net: liteeth: do not set len to 0 before printing it Sascha Hauer
2024-05-28  8:58 ` [PATCH v3 6/9] net: smc911x: Fix amount of words read from RX FIFO Sascha Hauer
2024-05-28  8:58 ` [PATCH v3 7/9] net: smc911x: do not read past the receive buffer Sascha Hauer
2024-05-28 13:29   ` Jules Maselbas
2024-05-28 14:23     ` [PATCH] fixup! " Sascha Hauer
2024-05-28 14:26     ` [PATCH v3 7/9] " Sascha Hauer
2024-05-28 14:37       ` Jules Maselbas
2024-05-28  8:58 ` Sascha Hauer [this message]
2024-05-28  8:58 ` [PATCH v3 9/9] net: let net rx hook return void Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528085806.1172689-9-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=wjq.sec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox