mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 3/4] ARM: bcm283x: fix compilation with debug_ll enabled
Date: Fri,  7 Jun 2024 03:12:58 +0300	[thread overview]
Message-ID: <20240607001259.107805-4-antonynpavlov@gmail.com> (raw)
In-Reply-To: <20240607001259.107805-1-antonynpavlov@gmail.com>

How to reproduce compilation error:

1. make multi_v7_defconfig
2. enable CONFIG_DEBUG_LL=y and CONFIG_DEBUG_RPI3_MINI_UART=y
3. make
...

include/mach/bcm283x/debug_ll.h: In function ‘debug_ll_init’:
include/mach/bcm283x/debug_ll.h:56:41: error: implicit declaration of
function ‘BIT’ [-Werror=imp
licit-function-declaration]
   56 | #define BCM2836_AUX_CLOCK_EN_UART       BIT(0) /* Bit 0 enables
      the Miniuart */
      |                                         ^~~

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 include/mach/bcm283x/debug_ll.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/mach/bcm283x/debug_ll.h b/include/mach/bcm283x/debug_ll.h
index 844305109aa..8bbff4fd9a2 100644
--- a/include/mach/bcm283x/debug_ll.h
+++ b/include/mach/bcm283x/debug_ll.h
@@ -52,6 +52,8 @@ static inline void debug_ll_write_reg(void __iomem *base, int reg, uint8_t val)
 	writeb(val, base + (reg << 2));
 }
 
+#include <linux/bits.h>
+
 #define BCM2836_AUX_CLOCK_ENB		0x3f215004 /* BCM2835 AUX Clock enable register */
 #define BCM2836_AUX_CLOCK_EN_UART	BIT(0) /* Bit 0 enables the Miniuart */
 
-- 
2.39.0




  parent reply	other threads:[~2024-06-07  0:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  0:12 [PATCH 0/4] pbl and debug_ll fixes Antony Pavlov
2024-06-07  0:12 ` [PATCH 1/4] pbl: enable image verification for MIPS and RISC-V too Antony Pavlov
2024-06-07  0:12 ` [PATCH 2/4] RISC-V: fix crash on start if CONFIG_IMAGE_COMPRESSION_NONE=y Antony Pavlov
2024-06-07  0:12 ` Antony Pavlov [this message]
2024-06-07  0:12 ` [PATCH 4/4] ARM: vexpress: make debug_ll work Antony Pavlov
2024-06-07  6:24   ` Antony Pavlov
2024-06-10 12:28     ` Sascha Hauer
2024-06-10 12:25 ` [PATCH 0/4] pbl and debug_ll fixes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240607001259.107805-4-antonynpavlov@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox