mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] globalvar: align parameter names in prototype with definition
@ 2024-07-03 18:56 Ahmad Fatoum
  0 siblings, 0 replies; only message in thread
From: Ahmad Fatoum @ 2024-07-03 18:56 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The prototype disagreed with the definition, possibly confusing users.
Fix it and while at it, add some missing commas, so the patch diff shows
the definition in the context.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/globalvar.c  | 4 ++--
 include/globalvar.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/globalvar.c b/common/globalvar.c
index 79624adcfe6f..ab224a27a130 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -309,9 +309,9 @@ static LIST_HEAD(globalvar_deprecated_list);
  *
  * This function is a helper for globalvars that are renamed from one
  * release to another. when a variable @oldname is found in the persistent
- * environment a warning is issued and its value is written to @newname.
+ * environment, a warning is issued and its value is written to @newname.
  *
- * Note that when both @oldname and @newname contain values then the values
+ * Note that when both @oldname and @newname contain values, then the values
  * existing in @newname are overwritten.
  */
 void globalvar_alias_deprecated(const char *oldname, const char *newname)
diff --git a/include/globalvar.h b/include/globalvar.h
index 5fdb70fca911..5b4c168b9170 100644
--- a/include/globalvar.h
+++ b/include/globalvar.h
@@ -44,7 +44,7 @@ int nvvar_remove(const char *name);
 void globalvar_print(void);
 
 void dev_param_init_from_nv(struct device *dev, const char *name);
-void globalvar_alias_deprecated(const char *newname, const char *oldname);
+void globalvar_alias_deprecated(const char *oldname, const char *newname);
 
 #else
 static inline const char *globalvar_get(const char *name)
-- 
2.39.2




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-07-03 18:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-03 18:56 [PATCH] globalvar: align parameter names in prototype with definition Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox