From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 09 Aug 2024 16:24:49 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1scQXx-007rXJ-09 for lore@lore.pengutronix.de; Fri, 09 Aug 2024 16:24:49 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scQXv-0008MY-Qj for lore@pengutronix.de; Fri, 09 Aug 2024 16:24:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UbM9aMPNVnL6nqsgL3SkQxgg0EbvPwTQkWXLPQ/Brow=; b=WnzPCP3Xc+i31IOJOdMV7dqghP 8fnO4K03h8cHdihXRzCbRdbT4M5ETFzQ9yIPcmKZJqI0E81W3/ZBEbej8hILnkTR+0BH4zOhHVy2E +KUlh/aHI9YUilxpYQSyGQ13yahglt/2tqgGmYj5i94rnM9PmLWWnL77J3pEo8Jah4SS1qoOLRs8d iKLnBg4NwufZonC15riAt1BqQNekxwuiAJetBGNhCzs1wKNIb3Ue7XNwWm6EdC+S90PC8tZILI0Pe +L5O5ys0kMNlK6WNhS8N9+fsxffEhAkJ0Z+R1NV6hYtFkbaI0XTTEDDqqJ/FebodCjyPoWH7mXN5H ftVRvoKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1scQXV-0000000BWOw-3H4t; Fri, 09 Aug 2024 14:24:21 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1scQXJ-0000000BWEb-0Hd8 for barebox@lists.infradead.org; Fri, 09 Aug 2024 14:24:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1scQXH-0007p7-MU; Fri, 09 Aug 2024 16:24:07 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1scQXH-005gea-5x; Fri, 09 Aug 2024 16:24:07 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1scQXH-001K4s-0I; Fri, 09 Aug 2024 16:24:07 +0200 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Fri, 9 Aug 2024 16:24:02 +0200 Message-Id: <20240809142405.315244-9-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240809142405.315244-1-a.fatoum@pengutronix.de> References: <20240809142405.315244-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240809_072409_183953_3BA65941 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 08/11] gpiolib: use dev_gpiod_get_index device node argument throughout X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) dev_gpiod_get_index takes both a consumer device and a consumer device tree node. The consumer device tree node should be used for all lookups, but it was used only for one of two lookups so far. This would break using the function on subnodes of a device, so remedy that. Signed-off-by: Ahmad Fatoum --- drivers/gpio/gpiolib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 4a1792a8df1f..5d5458374869 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1018,8 +1018,7 @@ struct gpio_desc *dev_gpiod_get_index(struct device *dev, if (!pp) return ERR_PTR(-ENOENT); - gpio = of_get_named_gpio_flags(dev->device_node, pp->name, - index, &of_flags); + gpio = of_get_named_gpio_flags(np, pp->name, index, &of_flags); if (!gpio_is_valid(gpio)) return ERR_PTR(gpio < 0 ? gpio : -EINVAL); -- 2.39.2