mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/3] debug_ll: ns16550: fix prototype in documentation comment
Date: Wed, 14 Aug 2024 18:14:33 +0200	[thread overview]
Message-ID: <20240814161435.566270-1-a.fatoum@pengutronix.de> (raw)

The functions were changed to take a base parameter, so they can be used
with PBL console instead of just DEBUG_LL. Update the comment to reflect
the current state of the code.

Fixes: e64990099c8f ("debug_ll ns16550: Add base address argument to register functions")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/debug_ll/ns16550.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/debug_ll/ns16550.h b/include/debug_ll/ns16550.h
index fce113574fd0..2bad7a43ca91 100644
--- a/include/debug_ll/ns16550.h
+++ b/include/debug_ll/ns16550.h
@@ -7,8 +7,8 @@
  * Early debugging functions for the NS16550
  * This file needs register access functions declared as:
  *
- * uint8_t debug_ll_read_reg(int reg);
- * void debug_ll_write_reg(int reg, uint8_t val);
+ * uint8_t debug_ll_read_reg(void __iomem *base, int reg);
+ * void debug_ll_write_reg(void __iomem *base, int reg, uint8_t val);
  */
 #define NS16550_THR	0x0
 #define NS16550_RBR	0x0
-- 
2.39.2




             reply	other threads:[~2024-08-14 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 16:14 Ahmad Fatoum [this message]
2024-08-14 16:14 ` [PATCH 2/3] openrisc: implement C debug_ll for NS16550 Ahmad Fatoum
2024-08-14 16:14 ` [PATCH 3/3] ci: container: downgrade OpenRISC toolchain from 14.2.0 to 13.1.0 Ahmad Fatoum
2024-08-15  8:49   ` (subset) " Sascha Hauer
2024-08-18  7:14   ` Stafford Horne
2024-08-18 17:09     ` Ahmad Fatoum
2024-08-22 16:43       ` Ahmad Fatoum
2024-08-23  6:21         ` Stafford Horne
2024-08-15  8:50 ` (subset) [PATCH 1/3] debug_ll: ns16550: fix prototype in documentation comment Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814161435.566270-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox