From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] ARM: semihosting: use svc instead of incorrect bkpt in DEBUG_LL
Date: Thu, 22 Aug 2024 13:56:30 +0200 [thread overview]
Message-ID: <20240822115630.1183874-1-a.fatoum@pengutronix.de> (raw)
The semihosting DEBUG_LL support was tested on ARM64. Trying it out on
ARM32 leads to a hanging system, because the DEBUG_LL handler used the
wrong instruction (breakpoint) instead of what the normal semihosting
implementation uses (supervisor call).
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/include/asm/semihosting.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/semihosting.h b/arch/arm/include/asm/semihosting.h
index 2219e858d040..bdfe472eedc0 100644
--- a/arch/arm/include/asm/semihosting.h
+++ b/arch/arm/include/asm/semihosting.h
@@ -27,8 +27,8 @@ static inline void semihosting_putc(void *unused, int c)
"push {%0}\n"
"mov r1, sp\n"
"mov r0, #0x03\n"
- ARM( "bkpt #0x123456\n")
- THUMB( "bkpt #0xAB\n")
+ ARM( "svc #0x123456\n")
+ THUMB( "svc #0xAB\n")
"pop {%0}\n"
: /* No outputs */
: "r" (c)
--
2.39.2
next reply other threads:[~2024-08-22 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 11:56 Ahmad Fatoum [this message]
2024-08-23 8:05 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822115630.1183874-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox