mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH v3 06/15] keytoc: make key name hint optional
Date: Fri,  6 Sep 2024 12:40:19 +0200	[thread overview]
Message-ID: <20240906104028.2187872-7-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20240906104028.2187872-1-s.hauer@pengutronix.de>

The key name hint is used in barebox to find a key without iterating
over all keys, but it's not required. Make the key name hint optional
to keytoc.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 scripts/keytoc.c | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/scripts/keytoc.c b/scripts/keytoc.c
index ecb33cbe47..85a7cd7319 100644
--- a/scripts/keytoc.c
+++ b/scripts/keytoc.c
@@ -9,6 +9,7 @@
  *
  */
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <string.h>
 #include <time.h>
@@ -602,9 +603,9 @@ static int gen_key(const char *keyname, const char *path)
 
 int main(int argc, char *argv[])
 {
-	char *path, *keyname;
 	int i, opt, ret;
 	char *outfile = NULL;
+	int keynum = 1;
 
 	outfilep = stdout;
 
@@ -652,21 +653,33 @@ int main(int argc, char *argv[])
 	}
 
 	for (i = optind; i < argc; i++) {
-		keyname = argv[i];
+		char *keyspec = argv[i];
+		char *keyname = NULL;
+		char *path, *freep = NULL;
 
-		path = strchr(keyname, ':');
-		if (!path) {
-			fprintf(stderr,
-				"keys must be given as <key_name_hint>:<crt>\n");
-			exit(1);
+		if (!strncmp(keyspec, "pkcs11:", 7)) {
+			path = keyspec;
+		} else {
+			path = strchr(keyspec, ':');
+			if (path) {
+				*path = 0;
+				path++;
+				keyname = keyspec;
+			} else {
+				path = keyspec;
+			}
 		}
 
-		*path = 0;
-		path++;
+		if (!keyname) {
+			asprintf(&freep, "key_%d", keynum++);
+			keyname = freep;
+		}
 
 		ret = gen_key(keyname, path);
 		if (ret)
 			exit(1);
+
+		free(freep);
 	}
 
 	if (dts) {
-- 
2.39.2




  parent reply	other threads:[~2024-09-06 10:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 10:40 [PATCH v3 00/15] Add ECDSA support for FIT image verification Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 01/15] keytoc: remove ECDSA dts support Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 02/15] keytoc: fail in case gen_key() fails Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 03/15] keytoc: fix ECDSA endianess problems Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 04/15] keytoc: remove duplicate __ENV__ check Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 05/15] crypto: Makefile: make simpler Sascha Hauer
2024-09-06 10:40 ` Sascha Hauer [this message]
2024-09-06 10:40 ` [PATCH v3 07/15] crypto: rsa: include key name hint into CONFIG_CRYPTO_RSA_KEY Sascha Hauer
2024-09-11  8:27   ` Ahmad Fatoum
2024-09-13  7:05     ` Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 08/15] crypto: rsa: encapsulate rsa keys in public keys struct Sascha Hauer
2024-09-11  8:33   ` Ahmad Fatoum
2024-09-13  7:06     ` Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 09/15] crypto: add public_key functions Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 10/15] crypto: builtin_keys: Allow to specify multiple keys in CONFIG_CRYPTO_PUBLIC_KEYS Sascha Hauer
2024-09-11  8:34   ` Ahmad Fatoum
2024-09-06 10:40 ` [PATCH v3 11/15] crypto: public-keys: use array of public_keys Sascha Hauer
2024-09-11  8:38   ` Ahmad Fatoum
2024-09-06 10:40 ` [PATCH v3 12/15] crypto: rsa: create static inline wrapper for rsa_verify() Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 13/15] Add elliptic curve cryptography (ECC) helper functions Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 14/15] crypto: add ECDSA support Sascha Hauer
2024-09-06 10:40 ` [PATCH v3 15/15] crypto: make RSA a visible option Sascha Hauer
2024-09-11  8:43 ` [PATCH v3 00/15] Add ECDSA support for FIT image verification Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906104028.2187872-7-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox