From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] lib: notifier: allow unregistering notifier in notifier_call_chain
Date: Tue, 10 Sep 2024 10:53:31 +0200 [thread overview]
Message-ID: <20240910085331.50498-1-a.fatoum@pengutronix.de> (raw)
It's possible for Linux notifiers to be removed from within the notifier
callback. Allow the same within barebox to avoid subtle bugs.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
lib/notifier.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/notifier.c b/lib/notifier.c
index c55ec22f94c2..3ca557f76df2 100644
--- a/lib/notifier.c
+++ b/lib/notifier.c
@@ -18,9 +18,9 @@ int notifier_chain_unregister(struct notifier_head *nh, struct notifier_block *n
int notifier_call_chain(struct notifier_head *nh, unsigned long val, void *v)
{
- struct notifier_block *entry;
+ struct notifier_block *entry, *tmp;
- list_for_each_entry(entry, &nh->blocks, list)
+ list_for_each_entry_safe(entry, tmp, &nh->blocks, list)
entry->notifier_call(entry, val, v);
return 0;
--
2.39.2
next reply other threads:[~2024-09-10 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 8:53 Ahmad Fatoum [this message]
2024-09-11 8:38 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910085331.50498-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox