From: Jonas Rebmann <jre@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
"open list:BAREBOX" <barebox@lists.infradead.org>
Cc: Jonas Rebmann <jre@pengutronix.de>
Subject: [PATCH] wd_core: remove obsolete watchdog list
Date: Wed, 18 Sep 2024 15:45:31 +0200 [thread overview]
Message-ID: <20240918-jre-remove-watchdog-list-v1-1-e56f1769e45e@pengutronix.de> (raw)
this patch fixes a null pointer derefence on imx28 related to the
incomplete removal of the watchdog list in 061e10.
Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
drivers/watchdog/wd_core.c | 1 -
include/watchdog.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/watchdog/wd_core.c b/drivers/watchdog/wd_core.c
index adb4c63909..d4de213fa5 100644
--- a/drivers/watchdog/wd_core.c
+++ b/drivers/watchdog/wd_core.c
@@ -237,7 +237,6 @@ int watchdog_deregister(struct watchdog *wd)
}
class_remove_device(&watchdog_class, &wd->dev);
- list_del(&wd->list);
return 0;
}
diff --git a/include/watchdog.h b/include/watchdog.h
index 2a0e9d1b41..eaea07910c 100644
--- a/include/watchdog.h
+++ b/include/watchdog.h
@@ -28,7 +28,6 @@ struct watchdog {
uint64_t last_ping;
int seconds_to_expire;
struct poller_async poller;
- struct list_head list;
int running; /* enum wdog_hw_running */
};
---
base-commit: 894166924badc0dea06c96476fb86f186e03c779
change-id: 20240918-jre-remove-watchdog-list-76667d3c3b26
Best regards,
--
Jonas Rebmann <jre@pengutronix.de>
next reply other threads:[~2024-09-18 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 13:45 Jonas Rebmann [this message]
2024-09-19 6:45 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918-jre-remove-watchdog-list-v1-1-e56f1769e45e@pengutronix.de \
--to=jre@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox