From: Sascha Hauer <s.hauer@pengutronix.de>
To: "open list:BAREBOX" <barebox@lists.infradead.org>
Subject: [PATCH 2/5] commands: splash: honour line_length
Date: Wed, 25 Sep 2024 16:34:50 +0200 [thread overview]
Message-ID: <20240925-graphics-v1-2-f1fe5d2cceec@pengutronix.de> (raw)
In-Reply-To: <20240925-graphics-v1-0-f1fe5d2cceec@pengutronix.de>
the splash command has an option for setting a background colour. This
doesn't always fill the whole screen as expected.
struct fb_info has a line_length field that specifies the length in
bytes of a single line. That length may be bigger than the actually
visible area as specified by xres. In this case filling the area as
calculated by xres*yres fills the invisible pixels between xres and
line_length, but it doesn't fill the whole visible area. Fix this by
iterating over the lines, filling the visible area of each line.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/splash.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/commands/splash.c b/commands/splash.c
index 2eb7c5dc39..74754392e2 100644
--- a/commands/splash.c
+++ b/commands/splash.c
@@ -62,9 +62,13 @@ static int do_splash(int argc, char *argv[])
buf = gui_screen_render_buffer(sc);
- if (do_bg)
- gu_memset_pixel(sc->info, buf, bg_color,
- sc->s.width * sc->s.height);
+ if (do_bg) {
+ int y;
+ for (y = 0; y < sc->s.height; y++) {
+ gu_memset_pixel(sc->info, buf + sc->info->line_length * y,
+ bg_color, sc->s.width);
+ }
+ }
ret = image_renderer_file(sc, &s, image_file);
if (ret > 0)
--
2.39.5
next prev parent reply other threads:[~2024-09-25 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 14:34 [PATCH 0/5] graphics updates Sascha Hauer
2024-09-25 14:34 ` [PATCH 1/5] graphic_utils: Clip to screen boundaries Sascha Hauer
2024-09-26 5:26 ` Ahmad Fatoum
2024-09-25 14:34 ` Sascha Hauer [this message]
2024-09-26 5:31 ` [PATCH 2/5] commands: splash: honour line_length Ahmad Fatoum
2024-09-26 6:48 ` Sascha Hauer
2024-09-25 14:34 ` [PATCH 3/5] gui: fix alpha blend Sascha Hauer
2024-09-26 5:33 ` Ahmad Fatoum
2024-09-25 14:34 ` [PATCH 4/5] fbconsole: make background pixels transparent Sascha Hauer
2024-09-26 5:38 ` Ahmad Fatoum
2024-09-26 7:02 ` Sascha Hauer
2024-09-25 14:34 ` [PATCH 5/5] fbconsole: actually store rows/cols Sascha Hauer
2024-09-26 5:39 ` Ahmad Fatoum
2024-09-27 10:38 ` [PATCH 0/5] graphics updates Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925-graphics-v1-2-f1fe5d2cceec@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox