From: Sascha Hauer <s.hauer@pengutronix.de>
To: "open list:BAREBOX" <barebox@lists.infradead.org>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v2 2/5] spi: spi-gpio: support different word widths
Date: Thu, 26 Sep 2024 13:21:38 +0200 [thread overview]
Message-ID: <20240926-spi-gpio-v2-2-3bf7b511c8c0@pengutronix.de> (raw)
In-Reply-To: <20240926-spi-gpio-v2-0-3bf7b511c8c0@pengutronix.de>
The spi-gpio driver only supports 8bit word width. Add support for
arbitrary word widths up to 32bit.
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/spi/gpio_spi.c | 57 ++++++++++++++++++++++++++++++++++++++++++--------
1 file changed, 48 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/gpio_spi.c b/drivers/spi/gpio_spi.c
index dc9f46ca45..d23abf3dfb 100644
--- a/drivers/spi/gpio_spi.c
+++ b/drivers/spi/gpio_spi.c
@@ -78,7 +78,7 @@ static inline u32 gpio_spi_txrx_word(struct spi_device *spi, unsigned nsecs,
return bitbang_txrx_be_cpha0(spi, nsecs, cpol, word, bits);
}
-static int gpio_spi_transfer_one(struct spi_device *spi, struct spi_transfer *t)
+static int gpio_spi_transfer_one_u8(struct spi_device *spi, struct spi_transfer *t)
{
bool read = (t->rx_buf) ? true : false;
u32 word = 0;
@@ -87,14 +87,59 @@ static int gpio_spi_transfer_one(struct spi_device *spi, struct spi_transfer *t)
for (n = 0; n < t->len; n++) {
if (!read)
word = ((const u8 *)t->tx_buf)[n];
- word = gpio_spi_txrx_word(spi, 0, word, 8);
+ word = gpio_spi_txrx_word(spi, 0, word, spi->bits_per_word);
+ if (read)
+ ((u8 *)t->rx_buf)[n] = word;
+ }
+
+ return 0;
+}
+
+static int gpio_spi_transfer_one_u16(struct spi_device *spi, struct spi_transfer *t)
+{
+ bool read = (t->rx_buf) ? true : false;
+ u32 word = 0;
+ int n;
+
+ for (n = 0; n < t->len / 2; n++) {
+ if (!read)
+ word = ((const u16 *)t->tx_buf)[n];
+ word = gpio_spi_txrx_word(spi, 0, word, spi->bits_per_word);
if (read)
- ((u8 *)t->rx_buf)[n] = word & 0xff;
+ ((u16 *)t->rx_buf)[n] = word;
}
return 0;
}
+static int gpio_spi_transfer_one_u32(struct spi_device *spi, struct spi_transfer *t)
+{
+ bool read = (t->rx_buf) ? true : false;
+ u32 word = 0;
+ int n;
+
+ for (n = 0; n < t->len / 4; n++) {
+ if (!read)
+ word = ((const u32 *)t->tx_buf)[n];
+ word = gpio_spi_txrx_word(spi, 0, word, spi->bits_per_word);
+ if (read)
+ ((u32 *)t->rx_buf)[n] = word;
+ }
+
+ return 0;
+}
+
+static int gpio_spi_transfer_one(struct spi_device *spi, struct spi_transfer *t)
+{
+ if (spi->bits_per_word <= 8)
+ return gpio_spi_transfer_one_u8(spi, t);
+ if (spi->bits_per_word <= 16)
+ return gpio_spi_transfer_one_u16(spi, t);
+ if (spi->bits_per_word <= 32)
+ return gpio_spi_transfer_one_u32(spi, t);
+ return -EINVAL;
+}
+
static int gpio_spi_transfer(struct spi_device *spi, struct spi_message *msg)
{
struct spi_transfer *t;
@@ -120,12 +165,6 @@ static int gpio_spi_transfer(struct spi_device *spi, struct spi_message *msg)
static int gpio_spi_setup(struct spi_device *spi)
{
- if (spi->bits_per_word != 8) {
- dev_err(spi->master->dev, "master does not support %d bits per word\n",
- spi->bits_per_word);
- return -EINVAL;
- }
-
return 0;
}
--
2.39.5
next prev parent reply other threads:[~2024-09-26 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 11:21 [PATCH v2 0/5] spi-gpio updates Sascha Hauer
2024-09-26 11:21 ` [PATCH v2 1/5] spi: spi-gpio: actually delay in spidelay() Sascha Hauer
2024-09-26 11:21 ` Sascha Hauer [this message]
2024-09-26 11:21 ` [PATCH v2 3/5] spi: spi-gpio: switch to new gpio binding Sascha Hauer
2024-09-26 11:21 ` [PATCH v2 4/5] spi: spi-gpio: deassert CS during setup Sascha Hauer
2024-09-26 11:21 ` [PATCH v2 5/5] spi: spi-gpio: switch to gpiod api Sascha Hauer
2024-09-27 10:40 ` [PATCH v2 0/5] spi-gpio updates Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926-spi-gpio-v2-2-3bf7b511c8c0@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox