From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Denis Orlov <denorl2009@gmail.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 1/6] dma: make DMA_ADDRESS_BROKEN type-safe
Date: Mon, 14 Oct 2024 14:58:38 +0200 [thread overview]
Message-ID: <20241014125843.2064532-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20241014125843.2064532-1-a.fatoum@pengutronix.de>
Defining it as void pointer makes it possible to plug this address
everywhere a non-const pointer is accepted.
To make erroneous use less likely, let's give it a proper type.
No functional change expected and if something breaks, it was most
likely already buggy.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
include/dma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/dma.h b/include/dma.h
index c2b1bee358ae..101116f58466 100644
--- a/include/dma.h
+++ b/include/dma.h
@@ -15,7 +15,7 @@
#include <asm/io.h>
#include <device.h>
-#define DMA_ADDRESS_BROKEN NULL
+#define DMA_ADDRESS_BROKEN ((dma_addr_t *)NULL)
#ifndef DMA_ALIGNMENT
#define DMA_ALIGNMENT 32
--
2.39.5
next prev parent reply other threads:[~2024-10-14 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:58 [PATCH 0/6] dma: give dma_alloc_coherent a device parameter Ahmad Fatoum
2024-10-14 12:58 ` Ahmad Fatoum [this message]
2024-10-14 12:58 ` [PATCH 2/6] video: stm: use DMA_ADDRESS_BROKEN instead of NULL Ahmad Fatoum
2024-10-14 12:58 ` [PATCH 3/6] crypto: caam - pbl-init: " Ahmad Fatoum
2024-10-14 12:58 ` [PATCH 4/6] net: designware: don't use dma_mapping_error for non-streaming DMA Ahmad Fatoum
2024-10-14 12:58 ` [PATCH 5/6] net: macb: fix DMA_ADDRESS_BROKEN in the coherent ring allocations Ahmad Fatoum
2024-10-14 12:58 ` [PATCH 6/6] dma: give dma_alloc_coherent a device parameter Ahmad Fatoum
2024-10-15 7:41 ` [PATCH 0/6] " Sascha Hauer
2024-10-18 8:39 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014125843.2064532-2-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=denorl2009@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox