From: Sebastien Bourdelin <sebastien.bourdelin@gmail.com>
To: barebox@lists.infradead.org
Cc: a.fatoum@pengutronix.de, sebastien.bourdelin@rtone.fr,
oss-contrib@rtone.fr
Subject: [PATCH v3 4/4] mci: bcm2835: set timeout value to 100ms
Date: Wed, 6 Nov 2024 16:37:02 +0100 [thread overview]
Message-ID: <20241106153702.858977-5-sebastien.bourdelin@rtone.fr> (raw)
In-Reply-To: <20241106153702.858977-1-sebastien.bourdelin@rtone.fr>
As mentionned in the Raspberry Pi4 bootrom Changelog [1]:
"Increase timeout of early SD/EMMC commands to 100ms".
The BCM2711 SDHCI can take up to 100ms to complete a command.
Without this change, we had noticed that Barebox sometime stay stucked
on a timeout error while trying to boot Linux from the eMMC.
[1] https://github.com/raspberrypi/rpi-eeprom/blob/master/firmware-2711/release-notes.md#2022-03-10---promote-the-2022-03-10-beta-release-to-lateststable
Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@rtone.fr>
---
Changes v2 -> v3:
- Fix email author and signed-off
Changes v1 -> v2:
- cmd can't be null, remove the check (suggested by Sascha Hauer)
---
drivers/mci/mci-bcm2835.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
index cbf99ee7ca..ff4c6d803c 100644
--- a/drivers/mci/mci-bcm2835.c
+++ b/drivers/mci/mci-bcm2835.c
@@ -128,6 +128,9 @@ static int bcm2835_mci_request(struct mci_host *mci, struct mci_cmd *cmd,
block_data |= data->blocksize;
}
+ /* BCM2xxx SDHCI might take up to 100ms to complete a command */
+ cmd->busy_timeout = 100;
+
ret = sdhci_wait_idle_data(&host->sdhci, cmd);
if (ret)
return ret;
--
2.47.0
next prev parent reply other threads:[~2024-11-06 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 15:36 [PATCH v3 0/4] Add a struct mci_cmd::busy_timeout member Sebastien Bourdelin
2024-11-06 15:36 ` [PATCH v3 1/4] mci: add a busy_timeout member to the struct mci_cmd Sebastien Bourdelin
2024-11-06 15:37 ` [PATCH v3 2/4] mci: zeroed all structs mci_cmd instances Sebastien Bourdelin
2024-11-06 15:37 ` [PATCH v3 3/4] mci: sdhci: use the busy_timeout value in the sdhci_wait_idle functions Sebastien Bourdelin
2024-11-06 15:37 ` Sebastien Bourdelin [this message]
2024-11-07 9:39 ` [PATCH v3 0/4] Add a struct mci_cmd::busy_timeout member Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106153702.858977-5-sebastien.bourdelin@rtone.fr \
--to=sebastien.bourdelin@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=oss-contrib@rtone.fr \
--cc=sebastien.bourdelin@rtone.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox