mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "open list:BAREBOX" <barebox@lists.infradead.org>
Subject: [PATCH 4/4] fs: tftp: Set default window size to 1
Date: Thu, 07 Nov 2024 08:23:33 +0100	[thread overview]
Message-ID: <20241107-fs-tftp-v1-4-39d7e1cff418@pengutronix.de> (raw)
In-Reply-To: <20241107-fs-tftp-v1-0-39d7e1cff418@pengutronix.de>

The TFTP window size feature is nice when it works, unfortunately it
often causes trouble as often packages get lost in the network buffers
causing retransmission delays. Disable this option by default.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/configs/imx_v7_defconfig   | 2 +-
 arch/arm/configs/multi_v7_defconfig | 2 +-
 fs/Kconfig                          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
index d3def0ece0..72833eb09f 100644
--- a/arch/arm/configs/imx_v7_defconfig
+++ b/arch/arm/configs/imx_v7_defconfig
@@ -225,7 +225,7 @@ CONFIG_SYSCON_REBOOT_MODE=y
 CONFIG_POWER_RESET_SYSCON=y
 CONFIG_FS_EXT4=y
 CONFIG_FS_TFTP=y
-CONFIG_FS_TFTP_MAX_WINDOW_SIZE=8
+CONFIG_FS_TFTP_MAX_WINDOW_SIZE=1
 CONFIG_FS_NFS=y
 CONFIG_FS_FAT=y
 CONFIG_FS_FAT_WRITE=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 97b01fd812..5b739a0f3b 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -344,7 +344,7 @@ CONFIG_VIRTIO_MMIO=y
 CONFIG_FS_CRAMFS=y
 CONFIG_FS_EXT4=y
 CONFIG_FS_TFTP=y
-CONFIG_FS_TFTP_MAX_WINDOW_SIZE=8
+CONFIG_FS_TFTP_MAX_WINDOW_SIZE=1
 CONFIG_FS_NFS=y
 CONFIG_FS_FAT=y
 CONFIG_FS_FAT_WRITE=y
diff --git a/fs/Kconfig b/fs/Kconfig
index e02cb939a5..27981b6444 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -47,7 +47,7 @@ config FS_TFTP_MAX_WINDOW_SIZE
 	int
 	prompt "maximum tftp window size (RFC 7440)"
 	depends on FS_TFTP
-	default 128
+	default 1
 	range 1 128
 	help
 	  The maximum allowed tftp "windowsize" (RFC 7440).  Higher

-- 
2.39.5




  parent reply	other threads:[~2024-11-07  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07  7:23 [PATCH 0/4] some fs/tftp updates Sascha Hauer
2024-11-07  7:23 ` [PATCH 1/4] fs: open loopback device before using it Sascha Hauer
2024-11-07  7:23 ` [PATCH 2/4] fs: tftp: cache dentries for some time Sascha Hauer
2024-11-07  7:23 ` [PATCH 3/4] fs: kill invalid dentries Sascha Hauer
2024-11-07  7:23 ` Sascha Hauer [this message]
2024-11-08 13:26 ` [PATCH 0/4] some fs/tftp updates Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241107-fs-tftp-v1-4-39d7e1cff418@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox