mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master] usb: typec: fix freeing uninitialized memory
Date: Fri, 22 Nov 2024 10:53:26 +0100	[thread overview]
Message-ID: <20241122095326.2877232-1-a.fatoum@pengutronix.de> (raw)

When the code was first added, a kzalloc was allocating the memory for
the struct device. This has been recently changed to malloc as a
shifting of the header caused the function to be no longer defined.

malloc() doesn't zero the memory though, leading to a potential freeing
of uninitialized memory in dev_set_name.

Fix this by using calloc() instead. Reintroducing kzalloc() would be
fine too, but calloc() saves some space, because it guarantees a smaller
alignment.

Fixes: d9fa8b26b60c ("usb: typec: fix compile test with CONFIG_SANDBOX")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/usb/typec/class.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 495ac794622f..9f9b4d6ca8f3 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -142,7 +142,7 @@ struct typec_port *typec_register_port(struct device *parent,
 	const char *alias;
 	int ret;
 
-	port = malloc(sizeof(*port));
+	port = calloc(sizeof(*port), 1);
 	if (!port)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.39.5




             reply	other threads:[~2024-11-22  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22  9:53 Ahmad Fatoum [this message]
2024-11-22 10:28 ` Marco Felsch
2024-11-22 10:34   ` Ahmad Fatoum
2024-11-25  8:14 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241122095326.2877232-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox