From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 29 Nov 2024 14:07:20 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tH0iO-001rkT-1G for lore@lore.pengutronix.de; Fri, 29 Nov 2024 14:07:20 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tH0iO-0002bx-AQ for lore@pengutronix.de; Fri, 29 Nov 2024 14:07:20 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=98DRkh/LaV8NG87UIrjg2+e5ItxGxZukGpHJLmidCww=; b=l7kgpuUja5EM3GRsoiC/5M8EXr 0QiAlYgh+1TVFVFsocxw6XXF7zAOUMqJyX070fBhGNdp1/iKQ5AgewhfzQAWPwts4LmQR7ypC01Nl H3wCGETp1lfOvvZBdmu4rlbHwqnBLv6Uvts/porwtesjGh7OJ9/BE+Lpt4oJddnP/4caECchpjyiN O7hKH+x7VG089w6eDG0iQzHuOu5Uh2ttiDa9eg24VNaP94WHmG6IrTSaAbPSY6O98Jl4y918FURZv QXJIh+ebxMsE2tkuIdbGxUPuOGvHq8kYdenAsNPaZ82ZfCVnOSkBFvdzRW5I6HoskUTOsKKWazxxF kNy00OAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tH0iE-000000009Jb-2rym; Fri, 29 Nov 2024 13:07:10 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGzhK-000000001Ox-2D4T for barebox@lists.infradead.org; Fri, 29 Nov 2024 12:02:12 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tGzhJ-0001MF-6Y; Fri, 29 Nov 2024 13:02:09 +0100 Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tGzhI-000mLm-0E; Fri, 29 Nov 2024 13:02:08 +0100 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tGzQ9-000vyS-2K; Fri, 29 Nov 2024 12:44:25 +0100 From: Sascha Hauer Date: Fri, 29 Nov 2024 12:44:28 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20241129-k3-r5-v1-13-67c4bb42a5c7@pengutronix.de> References: <20241129-k3-r5-v1-0-67c4bb42a5c7@pengutronix.de> In-Reply-To: <20241129-k3-r5-v1-0-67c4bb42a5c7@pengutronix.de> To: "open list:BAREBOX" X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1732880665; l=1707; i=s.hauer@pengutronix.de; s=20230412; h=from:subject:message-id; bh=Opa9imGjIOmT2Zemeh/fGI5DJlRSiyOTVDkPGAGmiYU=; b=kcKj9h/5q4gYRJJCAY5O55RK/8RVRenZJbOnUSbaf/LdP4Et+f6WW5S4qvfJIachPCfrUsF59 NH/Q3g+LOqJAR7vOMX6fa9Fnjkt1JQPW4QquwJ/wwJqkZreCYhTVfk2 X-Developer-Key: i=s.hauer@pengutronix.de; a=ed25519; pk=4kuc9ocmECiBJKWxYgqyhtZOHj5AWi7+d0n/UjhkwTg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241129_040210_613859_300E23F3 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 13/20] elf: use iomem regions as fallback when loading to non-sdram memory X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The ELF code uses request_sdram_region() to request the regions the binary shall be copied to. However, not all of these regions are actually SDRAM. Some specialized ELF files might also use SoC SRAM which is not registered as SDRAM, so use request_region as a fallback in these cases. This is needed on the TI K3 AM625 SoC to successfully load the ti-dm firmware binary. Signed-off-by: Sascha Hauer --- common/elf.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/common/elf.c b/common/elf.c index 62f793010f..cfe84939af 100644 --- a/common/elf.c +++ b/common/elf.c @@ -18,6 +18,7 @@ struct elf_section { struct list_head list; struct resource *r; void *phdr; + bool is_iomem_region; }; static int elf_request_region(struct elf_image *elf, resource_size_t start, @@ -33,8 +34,12 @@ static int elf_request_region(struct elf_image *elf, resource_size_t start, r_new = request_sdram_region("elf_section", start, size); if (!r_new) { - pr_err("Failed to request region: %pa %pa\n", &start, &size); - return -EINVAL; + r_new = request_iomem_region("elf_section", start, size); + if (!r_new) { + pr_err("Failed to request region: %pa %pa\n", &start, &size); + return -EINVAL; + } + r->is_iomem_region = true; } r->r = r_new; @@ -50,7 +55,10 @@ static void elf_release_regions(struct elf_image *elf) struct elf_section *r, *r_tmp; list_for_each_entry_safe(r, r_tmp, list, list) { - release_sdram_region(r->r); + if (r->is_iomem_region) + release_region(r->r); + else + release_sdram_region(r->r); list_del(&r->list); free(r); } -- 2.39.5