mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] kbuild: fix clangd warning with GCC compile_commands.json
@ 2025-01-07 12:24 Ahmad Fatoum
  2025-01-08 14:32 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-01-07 12:24 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

If barebox is configured to pass -ftrivial-auto-var-init=zero as
argument to GCC, the compile_commands.json will list it prompting clang
to complain:

  '-ftrivial-auto-var-init=zero' hasn't been enabled; enable it at your own
  peril for benchmarking purpose only with
  '-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang'

When built with clang, this option is supplied, so we only see this
warning when configuring barebox with GCC, but using clangd via LSP.

Fix this by adding this option unconditionally.

Fixes: f41c4d7c5649 ("Makefile: add LLVM/clang support")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 .clangd | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.clangd b/.clangd
index 4057270b2a83..027fb11d7a11 100644
--- a/.clangd
+++ b/.clangd
@@ -1,2 +1,3 @@
 CompileFlags:
   Remove: [ -mabi=lp64, -fno-allow-store-data-races]
+  Add: [ -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang ]
-- 
2.39.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] kbuild: fix clangd warning with GCC compile_commands.json
  2025-01-07 12:24 [PATCH master] kbuild: fix clangd warning with GCC compile_commands.json Ahmad Fatoum
@ 2025-01-08 14:32 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-01-08 14:32 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Tue, 07 Jan 2025 13:24:26 +0100, Ahmad Fatoum wrote:
> If barebox is configured to pass -ftrivial-auto-var-init=zero as
> argument to GCC, the compile_commands.json will list it prompting clang
> to complain:
> 
>   '-ftrivial-auto-var-init=zero' hasn't been enabled; enable it at your own
>   peril for benchmarking purpose only with
>   '-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang'
> 
> [...]

Applied, thanks!

[1/1] kbuild: fix clangd warning with GCC compile_commands.json
      https://git.pengutronix.de/cgit/barebox/commit/?id=2c151ad3fb19 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-08 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-07 12:24 [PATCH master] kbuild: fix clangd warning with GCC compile_commands.json Ahmad Fatoum
2025-01-08 14:32 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox