From: Marco Felsch <m.felsch@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "open list:BAREBOX" <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 07/14] fip: add function to calculate a sha256 over FIP image
Date: Tue, 11 Mar 2025 14:43:49 +0100 [thread overview]
Message-ID: <20250311134349.kresmi7nbwffa2pn@pengutronix.de> (raw)
In-Reply-To: <20250311-am625-secure-v2-7-3cbbfa092346@pengutronix.de>
On 25-03-11, Sascha Hauer wrote:
> This adds fip_sha256() to calculate a sha256 over a FIP image.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> include/fiptool.h | 3 +++
> lib/fip.c | 23 ++++++++++++++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/include/fiptool.h b/include/fiptool.h
> index bb63a79c16..73b0fbe398 100644
> --- a/include/fiptool.h
> +++ b/include/fiptool.h
> @@ -38,6 +38,7 @@ struct fip_state {
> size_t nr_image_descs;
> int verbose;
> void *buffer;
> + size_t bufsize;
> bool buf_no_free;
> };
>
> @@ -100,4 +101,6 @@ extern toc_entry_t plat_def_toc_entries[];
>
> struct fip_state *fip_image_open(const char *filename, size_t offset);
>
> +int fip_sha256(struct fip_state *fip, char *hash);
> +
> #endif /* FIPTOOL_H */
> diff --git a/lib/fip.c b/lib/fip.c
> index 8086b43412..7a5e3dc844 100644
> --- a/lib/fip.c
> +++ b/lib/fip.c
> @@ -24,6 +24,7 @@
> #include <libfile.h>
> #include <fs.h>
> #include <linux/kernel.h>
> +#include <digest.h>
>
> #include <fip.h>
> #include <fiptool.h>
> @@ -168,6 +169,7 @@ static int fip_do_parse_buf(struct fip_state *fip, void *buf, size_t size,
> int terminated = 0;
>
> fip->buffer = buf;
> + fip->bufsize = size;
>
> bufend = fip->buffer + size;
>
> @@ -570,10 +572,29 @@ struct fip_state *fip_image_open(const char *filename, size_t offset)
> close(fd);
>
> return fip_state;
> -
> err:
> close(fd);
> fip_free(fip_state);
>
> return ERR_PTR(ret);
> }
> +
> +int fip_sha256(struct fip_state *fip, char *hash)
> +{
> + struct digest *d;
> + int ret;
> +
> + d = digest_alloc_by_algo(HASH_ALGO_SHA256);
> + if (!d)
> + return -ENOSYS;
> +
> + digest_init(d);
> +
> + digest_update(d, fip->buffer, fip->bufsize);
> +
> + ret = digest_final(d, hash);
> +
> + digest_free(d);
> +
> + return ret;
> +}
>
> --
> 2.39.5
>
>
>
next prev parent reply other threads:[~2025-03-11 13:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 12:25 [PATCH v2 00/14] am625: support secure loading of full barebox Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 01/14] firmware: always generate sha256sum Sascha Hauer
2025-03-11 13:13 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 02/14] firmware: add function to verify next image Sascha Hauer
2025-03-11 13:19 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 03/14] ARM: k3: r5: drop loading of separate binaries Sascha Hauer
2025-03-11 13:20 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 04/14] ARM: k3: r5: add proper error handling Sascha Hauer
2025-03-11 13:21 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 05/14] fip: rework fip_image_open() Sascha Hauer
2025-03-11 13:42 ` Marco Felsch
2025-03-12 11:02 ` Sascha Hauer
2025-03-12 11:45 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 06/14] fip: fix wrong function call Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 07/14] fip: add function to calculate a sha256 over FIP image Sascha Hauer
2025-03-11 13:43 ` Marco Felsch [this message]
2025-03-11 12:25 ` [PATCH v2 08/14] ARM: am625: support hash verification of full barebox Sascha Hauer
2025-03-11 13:44 ` Marco Felsch
2025-03-11 12:25 ` [PATCH v2 09/14] ARM: k3: add support for authenticating images against the ROM API Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 10/14] ARM: k3: r5: delete fip image when it can't be opened Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 11/14] ARM: k3: r5: Allow to authenticate next image by ROM API Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 12/14] scripts/k3img: remove temporary files Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 13/14] scripts: add k3sign Sascha Hauer
2025-03-11 12:25 ` [PATCH v2 14/14] ARM: k3: r5: select HAS_INSECURE_DEFAULTS when necessary Sascha Hauer
2025-03-11 13:46 ` Marco Felsch
2025-03-12 10:22 ` [PATCH v2 00/14] am625: support secure loading of full barebox Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311134349.kresmi7nbwffa2pn@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox