mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH 16/22] of: fdt: silence possible static analyzer false positive
Date: Thu, 13 Mar 2025 08:34:39 +0100	[thread overview]
Message-ID: <20250313073445.764875-17-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20250313073445.764875-1-a.fatoum@pengutronix.de>

clang-analyzer warns that aligning up newsize may end up causing an
overflow. Let's stop well before that by bailing out if the unaligned
size itself wouldn't fit into a malloc allocation anyway.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/of/fdt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 6c554af61f6f..43bb73b7a2df 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -378,6 +378,9 @@ static void *memalign_realloc(void *orig, size_t oldsize, size_t newsize)
 	int align;
 	void *newbuf;
 
+	if (newsize > MALLOC_MAX_SIZE)
+		return NULL;
+
 	/*
 	 * ARM Linux uses a single 1MiB section (with 1MiB alignment)
 	 * for mapping the devicetree, so we are not allowed to cross
-- 
2.39.5




  parent reply	other threads:[~2025-03-13  7:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  7:34 [PATCH 00/22] add support for clang-analyzer with scan-build Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 01/22] kbuild: " Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 02/22] soc: ti: k3-navss-ringacc: fix COMPILE_TEST link error Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 03/22] treewide: fix missing headers in sandbox allyesconfig Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 04/22] drivers: don't cast pointer directly to enum Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 05/22] firmware: arm_scmi: smc: compile only for ARM Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 06/22] video: stm32-ltdc: fix printing uninitialized variable Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 07/22] usb: core: remove unnecessary comparison Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 08/22] ddr_spd: fix always true sub-condition Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 09/22] hush: fix make_string behavior on empty strings Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 10/22] nvmem: fix clang-analyzer false-positive use of uninitialized value Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 11/22] string: initialize string array in string selftest Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 12/22] commands: ubsan: hide zero division in test Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 13/22] crypto: ecc: fix clang-analyzer warning about NULL dereference Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 14/22] mci_spi: fix possible use of uninitialized variable Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 15/22] mtd: have mtd_read populate retlen always Ahmad Fatoum
2025-03-13  7:34 ` Ahmad Fatoum [this message]
2025-03-13  7:34 ` [PATCH 17/22] ubi: workaround zero division on malformed input in ubi_assert Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 18/22] video: Rockchip: fix zero division in rk3588_calc_cru_cfg Ahmad Fatoum
2025-03-13  8:09   ` [PATCH] fixup! " Ahmad Fatoum
2025-03-14 16:03   ` [PATCH 18/22] " Sascha Hauer
2025-03-13  7:34 ` [PATCH 19/22] lib: scatterlist: don't assert last element for empty sglist Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 20/22] scripts: omap3-usb-loader: fix clang-analyzer false-positive Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 21/22] clk: analogbits: wrpll-cln28hpc: bail out before zero division Ahmad Fatoum
2025-03-13  7:34 ` [PATCH 22/22] watchdog: stm32_iwdg: " Ahmad Fatoum
2025-03-14 16:04 ` [PATCH 00/22] add support for clang-analyzer with scan-build Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250313073445.764875-17-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox