From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 13 Mar 2025 08:49:02 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsdJP-00DTbm-0Z for lore@lore.pengutronix.de; Thu, 13 Mar 2025 08:49:02 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsdJN-0008G1-Ch for lore@pengutronix.de; Thu, 13 Mar 2025 08:49:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eT2mDBK6/lNVxlkT8ZAPvxtbmeuVgXCaBQJ5A0eTKtg=; b=kCUqv2BU3p48ZUtA4sftTQTUgg Ln9sLKIq5pCa+i8cgZa+t0uPz4h9tUShj75DfL77w/UftizKaXGjqM18cMUcrA8l7zoHfz/v2xZL9 5mRd1OT4Z6BQlg3VUcBPcszopEhk5Dvv+N140c2y4rvW/21UboQcvgvUGWr0RawrvYGxRCTqfIXYy w8mi+dvK64/z/0dk7GN9MvqxD+TSCaC8/jMg29YE+6TTR3SkzQsVmTz/5bx4M5vcKh2PbydVfgVzT t+CE1lsqnW2S9xsfItZkcYTt4avlyPusAf9Y5swh2FKF86liMYQy0Jzi1Bng/WKpkQywYUw17oJq4 zlfGHEvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsdIy-0000000AQd3-25OJ; Thu, 13 Mar 2025 07:48:36 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsd5j-0000000AOUn-3KuQ for barebox@lists.infradead.org; Thu, 13 Mar 2025 07:34:57 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsd5i-0005mY-H9; Thu, 13 Mar 2025 08:34:54 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsd5i-005Uvq-0v; Thu, 13 Mar 2025 08:34:54 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tsd5i-003pwb-0d; Thu, 13 Mar 2025 08:34:54 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 13 Mar 2025 08:34:29 +0100 Message-Id: <20250313073445.764875-7-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250313073445.764875-1-a.fatoum@pengutronix.de> References: <20250313073445.764875-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_003455_851249_FD401A4F X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 06/22] video: stm32-ltdc: fix printing uninitialized variable X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) ret is not initialized on failure to get the clock. Signed-off-by: Ahmad Fatoum --- drivers/video/stm32_ltdc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/stm32_ltdc.c b/drivers/video/stm32_ltdc.c index 6b91ee18b962..7ebd24d6d908 100644 --- a/drivers/video/stm32_ltdc.c +++ b/drivers/video/stm32_ltdc.c @@ -269,10 +269,8 @@ static int ltdc_probe(struct device *dev) hw->regs = IOMEM(iores->start); hw->pclk = clk_get(dev, NULL); - if (IS_ERR(hw->pclk)) { - dev_err(dev, "peripheral clock get error %d\n", ret); - return PTR_ERR(hw->pclk); - } + if (IS_ERR(hw->pclk)) + return dev_errp_probe(dev, hw->pclk, "peripheral clock get\n"); for_each_available_child_of_node(dev->of_node, np) { struct ltdc_fb *priv; -- 2.39.5