From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 13 Mar 2025 08:49:06 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsdJT-00DTdx-0L for lore@lore.pengutronix.de; Thu, 13 Mar 2025 08:49:06 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsdJR-0008Ky-V7 for lore@pengutronix.de; Thu, 13 Mar 2025 08:49:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hOPA4lM/8koUKXkixAiwpuzyRmzom90NWKnTmHOdYQ0=; b=DfzvXYvnKDih60VuwTokbYn8MU TtWxxziQ4Yk9q781MsVF8qUNZkO49n+XpCaAn5qVmb2S36TlCae4XiHKCCGA086VyNiQb2Mtn+ReR MbdqnSYfF63xxLBIxP5Oq7Fu0XHCiP41+uwr02lDKjbHhL6/4k6uhdkstIGy8IzHUdxfw/T8YQhaV cF8yjtp3JMy8xa9nxIX75YfZNgQl35wpOm4JP6sorQgd87AoOJlXPtOHua5rvmFrKw5Wyw288y/Gr cyXPd5g8GqUYKwDphTyyRz8mWsI/DfwnRzHbkMoQCrn6MNf4NcYXZTL2nmP3pmVP9VHd3YA3OIyru KNPBOONQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsdJ0-0000000AQfr-2TM8; Thu, 13 Mar 2025 07:48:38 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsd5j-0000000AOUo-3SLR for barebox@lists.infradead.org; Thu, 13 Mar 2025 07:34:57 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsd5i-0005me-J6; Thu, 13 Mar 2025 08:34:54 +0100 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsd5i-005Uvu-14; Thu, 13 Mar 2025 08:34:54 +0100 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1tsd5i-003pwb-0l; Thu, 13 Mar 2025 08:34:54 +0100 From: Ahmad Fatoum To: barebox@lists.infradead.org Cc: Ahmad Fatoum Date: Thu, 13 Mar 2025 08:34:30 +0100 Message-Id: <20250313073445.764875-8-a.fatoum@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250313073445.764875-1-a.fatoum@pengutronix.de> References: <20250313073445.764875-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_003455_863748_E6B9E990 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: [PATCH 07/22] usb: core: remove unnecessary comparison X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) The GCC default is to treat enums without negative values in the enumerations as an unsigned int. clang seems to follow suit and clang-analyzer warns that speed < 0 can never happen. Therefore, drop this superfluous check. Signed-off-by: Ahmad Fatoum --- drivers/usb/core/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/common.c b/drivers/usb/core/common.c index 61ccc130244b..f255f97cdd4d 100644 --- a/drivers/usb/core/common.c +++ b/drivers/usb/core/common.c @@ -13,7 +13,7 @@ static const char *const speed_names[] = { const char *usb_speed_string(enum usb_device_speed speed) { - if (speed < 0 || speed >= ARRAY_SIZE(speed_names)) + if (speed >= ARRAY_SIZE(speed_names)) speed = USB_SPEED_UNKNOWN; return speed_names[speed]; } -- 2.39.5