[PATCH 0/6] compile test fixes

[PATCH 0/6] compile test fixes

[Jules Maselbas]

Small patches series of fixes discovered with a compile test on sandbox (x86_64)
The compile test has been against the next branch but all the patches applies on
commits that are already in the master branch.

Jules Maselbas (6):
  dma-devices: k3-udma: cleanup headers
  dma-devices: k3-udma: use snprintf instead of sprintf
  mfd: tps65219: add missing include
  pmdomain: ti-k3: add missing include
  pmdomain: ti-k3: remove trailing whitespace
  regulator: tps65219: add missing include

 drivers/dma/ti/k3-udma.c               | 5 ++---
 drivers/mfd/tps65219.c                 | 1 +
 drivers/pmdomain/ti/ti-k3.c            | 9 +++++----
 drivers/regulator/tps65219-regulator.c | 1 +
 4 files changed, 9 insertions(+), 7 deletions(-)

-- 
2.48.1

[PATCH 1/6] dma-devices: k3-udma: cleanup headers

[Jules Maselbas]

Remove include of `asm/cache.h` as it is not used.
Also remove the duplicated include `soc/ti/ti_sci_protocol.h`.
Add the include `common.h` for the missing declaration of sprintf.

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/dma/ti/k3-udma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 761898867d..8f46364145 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5,8 +5,8 @@
  */
 #define pr_fmt(fmt) "udma: " fmt
 
-#include <asm/cache.h>
 #include <io.h>
+#include <common.h>
 #include <malloc.h>
 #include <linux/bitops.h>
 #include <linux/sizes.h>
@@ -21,7 +21,6 @@
 #include <linux/bitmap.h>
 #include <driver.h>
 #include <linux/device.h>
-#include <soc/ti/ti_sci_protocol.h>
 
 #include "k3-udma-hwdef.h"
 #include "k3-psil-priv.h"
-- 
2.48.1

[PATCH 2/6] dma-devices: k3-udma: use snprintf instead of sprintf

[Jules Maselbas]

Replace the use of sprintf by snprintf, in this case sprintf could not
overflow because the size of uc::name is well chosen to be able to fit
the largest u32 integer.

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/dma/ti/k3-udma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 8f46364145..d32ed46b0f 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -2678,7 +2678,7 @@ static int k3_udma_probe(struct device *dev)
 		uc->config.mapped_channel_id = -1;
 		uc->config.default_flow_id = -1;
 		uc->config.dir = DMA_MEM_TO_MEM;
-		sprintf(uc->name, "UDMA chan%d\n", i);
+		snprintf(uc->name, sizeof(uc->name), "UDMA chan%d\n", i);
 		if (!i)
 			uc->in_use = true;
 	}
-- 
2.48.1

[PATCH 3/6] mfd: tps65219: add missing include

[Jules Maselbas]

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/mfd/tps65219.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c
index 854210537f..62280f2aa2 100644
--- a/drivers/mfd/tps65219.c
+++ b/drivers/mfd/tps65219.c
@@ -12,6 +12,7 @@
 #include <linux/regmap.h>
 #include <linux/mfd/tps65219.h>
 #include <linux/device.h>
+#include <linux/array_size.h>
 
 static const struct mfd_cell tps65219_cells[] = {
 	{ .name = "tps65219-regulator", },
-- 
2.48.1

[PATCH 4/6] pmdomain: ti-k3: add missing include

[Jules Maselbas]

The function basprintf was not defined, include common.h which includes
stdio.h and defines basprintf

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/pmdomain/ti/ti-k3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pmdomain/ti/ti-k3.c b/drivers/pmdomain/ti/ti-k3.c
index 33bffeaca0..f53e907386 100644
--- a/drivers/pmdomain/ti/ti-k3.c
+++ b/drivers/pmdomain/ti/ti-k3.c
@@ -8,6 +8,7 @@
 
 #define pr_fmt(fmt)     "ti-k3-pm-domain: " fmt
 
+#include <common.h>
 #include <io.h>
 #include <of_device.h>
 #include <malloc.h>
-- 
2.48.1

[PATCH 5/6] pmdomain: ti-k3: remove trailing whitespace

[Jules Maselbas]

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/pmdomain/ti/ti-k3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pmdomain/ti/ti-k3.c b/drivers/pmdomain/ti/ti-k3.c
index f53e907386..a2667a9847 100644
--- a/drivers/pmdomain/ti/ti-k3.c
+++ b/drivers/pmdomain/ti/ti-k3.c
@@ -321,14 +321,14 @@ static int ti_k3_pm_domain_on(struct generic_pm_domain *domain)
 	struct ti_k3_pm_domain *pd = to_ti_k3_pd(domain);
 
 	return ti_lpsc_transition(pd->lpsc, MDSTAT_STATE_ENABLE);
-}       
-        
+}
+
 static int ti_k3_pm_domain_off(struct generic_pm_domain *domain)
-{       
+{
 	struct ti_k3_pm_domain *pd = to_ti_k3_pd(domain);
 
 	return ti_lpsc_transition(pd->lpsc, MDSTAT_STATE_SWRSTDISABLE);
-}       
+}
 
 static struct ti_psc am625_psc[] = {
 	[0] = { .id = 0, .base = (void *)0x04000000 },
-- 
2.48.1

[PATCH 6/6] regulator: tps65219: add missing include

[Jules Maselbas]

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/regulator/tps65219-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
index da329660d6..9961638595 100644
--- a/drivers/regulator/tps65219-regulator.c
+++ b/drivers/regulator/tps65219-regulator.c
@@ -16,6 +16,7 @@
 #include <linux/regulator/of_regulator.h>
 #include <regulator.h>
 #include <linux/device.h>
+#include <linux/array_size.h>
 
 struct tps65219_regulator_irq_type {
 	const char *irq_name;
-- 
2.48.1

Re: [PATCH 0/6] compile test fixes

[Ahmad Fatoum]

Hi Jules,

On 3/14/25 11:40, Jules Maselbas wrote:
> Small patches series of fixes discovered with a compile test on sandbox (x86_64)
> The compile test has been against the next branch but all the patches applies on
> commits that are already in the master branch.

This partially duplicates fixes in my clang-analyzer series here:
https://lore.barebox.org/barebox/20250313073445.764875-1-a.fatoum@pengutronix.de/T/#t

Can you rebase?

Thanks,
Ahmad

> 
> Jules Maselbas (6):
>   dma-devices: k3-udma: cleanup headers
>   dma-devices: k3-udma: use snprintf instead of sprintf
>   mfd: tps65219: add missing include
>   pmdomain: ti-k3: add missing include
>   pmdomain: ti-k3: remove trailing whitespace
>   regulator: tps65219: add missing include
> 
>  drivers/dma/ti/k3-udma.c               | 5 ++---
>  drivers/mfd/tps65219.c                 | 1 +
>  drivers/pmdomain/ti/ti-k3.c            | 9 +++++----
>  drivers/regulator/tps65219-regulator.c | 1 +
>  4 files changed, 9 insertions(+), 7 deletions(-)
> 

Re: [PATCH 0/6] compile test fixes

[Jules Maselbas]

On Fri Mar 14, 2025 at 2:08 PM CET, Ahmad Fatoum wrote:
> Hi Jules,
>
> On 3/14/25 11:40, Jules Maselbas wrote:
>> Small patches series of fixes discovered with a compile test on sandbox (x86_64)
>> The compile test has been against the next branch but all the patches applies on
>> commits that are already in the master branch.
>
> This partially duplicates fixes in my clang-analyzer series here:
> https://lore.barebox.org/barebox/20250313073445.764875-1-a.fatoum@pengutronix.de/T/#t
>
> Can you rebase?

Only patch 6 is conflicting and can be dropped because it is already fixed by
9b815da01ff4b88c6634c4a7541c581a35ad96d8 ("treewide: fix missing headers in sandbox allyesconfig")

>
> Thanks,
> Ahmad
>
>> 
>> Jules Maselbas (6):
>>   dma-devices: k3-udma: cleanup headers
>>   dma-devices: k3-udma: use snprintf instead of sprintf
>>   mfd: tps65219: add missing include
>>   pmdomain: ti-k3: add missing include
>>   pmdomain: ti-k3: remove trailing whitespace
>>   regulator: tps65219: add missing include
>> 
>>  drivers/dma/ti/k3-udma.c               | 5 ++---
>>  drivers/mfd/tps65219.c                 | 1 +
>>  drivers/pmdomain/ti/ti-k3.c            | 9 +++++----
>>  drivers/regulator/tps65219-regulator.c | 1 +
>>  4 files changed, 9 insertions(+), 7 deletions(-)
>> 

Re: [PATCH 0/6] compile test fixes

[Ahmad Fatoum]

Hello Jules,

On 3/14/25 15:43, Jules Maselbas wrote:
> On Fri Mar 14, 2025 at 2:08 PM CET, Ahmad Fatoum wrote:
>> Hi Jules,
>>
>> On 3/14/25 11:40, Jules Maselbas wrote:
>>> Small patches series of fixes discovered with a compile test on sandbox (x86_64)
>>> The compile test has been against the next branch but all the patches applies on
>>> commits that are already in the master branch.
>>
>> This partially duplicates fixes in my clang-analyzer series here:
>> https://lore.barebox.org/barebox/20250313073445.764875-1-a.fatoum@pengutronix.de/T/#t
>>
>> Can you rebase?
> 
> Only patch 6 is conflicting and can be dropped because it is already fixed by
> 9b815da01ff4b88c6634c4a7541c581a35ad96d8 ("treewide: fix missing headers in sandbox allyesconfig")

Patch 3/6 and 4/6 as well as partially (?) 1/6 are also addressed by my
series. So even without conflict, applying this on top would lead to
addition of a now superfluous include.

Thanks,
Ahmad

> 
>>
>> Thanks,
>> Ahmad
>>
>>>
>>> Jules Maselbas (6):
>>>   dma-devices: k3-udma: cleanup headers
>>>   dma-devices: k3-udma: use snprintf instead of sprintf
>>>   mfd: tps65219: add missing include
>>>   pmdomain: ti-k3: add missing include
>>>   pmdomain: ti-k3: remove trailing whitespace
>>>   regulator: tps65219: add missing include
>>>
>>>  drivers/dma/ti/k3-udma.c               | 5 ++---
>>>  drivers/mfd/tps65219.c                 | 1 +
>>>  drivers/pmdomain/ti/ti-k3.c            | 9 +++++----
>>>  drivers/regulator/tps65219-regulator.c | 1 +
>>>  4 files changed, 9 insertions(+), 7 deletions(-)
>>>
> 
> 

Re: [PATCH 0/6] compile test fixes

[Jules Maselbas]

Hi Ahmad,

On Fri Mar 14, 2025 at 3:49 PM CET, Ahmad Fatoum wrote:
> Hello Jules,
>
> On 3/14/25 15:43, Jules Maselbas wrote:
>> On Fri Mar 14, 2025 at 2:08 PM CET, Ahmad Fatoum wrote:
>>> Hi Jules,
>>>
>>> On 3/14/25 11:40, Jules Maselbas wrote:
>>>> Small patches series of fixes discovered with a compile test on sandbox (x86_64)
>>>> The compile test has been against the next branch but all the patches applies on
>>>> commits that are already in the master branch.
>>>
>>> This partially duplicates fixes in my clang-analyzer series here:
>>> https://lore.barebox.org/barebox/20250313073445.764875-1-a.fatoum@pengutronix.de/T/#t
>>>
>>> Can you rebase?
>> 
>> Only patch 6 is conflicting and can be dropped because it is already fixed by
>> 9b815da01ff4b88c6634c4a7541c581a35ad96d8 ("treewide: fix missing headers in sandbox allyesconfig")
>
> Patch 3/6 and 4/6 as well as partially (?) 1/6 are also addressed by my
> series. So even without conflict, applying this on top would lead to
> addition of a now superfluous include.

Good point

I will send a v2, and drop unneeded patches

[PATCH v2 0/3] compile test cleanups

[Jules Maselbas]

Small cleanups patches

v2:
 - rebased on Ahmad clang-analyzer series, and dropped spurious changes

Jules Maselbas (3):
  dma-devices: k3-udma: remove duplicated include
  dma-devices: k3-udma: use snprintf instead of sprintf
  pmdomain: ti-k3: remove trailing whitespace

 drivers/dma/ti/k3-udma.c    | 3 +--
 drivers/pmdomain/ti/ti-k3.c | 8 ++++----
 2 files changed, 5 insertions(+), 6 deletions(-)

-- 
2.48.1

[PATCH v2 1/3] dma-devices: k3-udma: remove duplicated include

[Jules Maselbas]

Remove the duplicated include `soc/ti/ti_sci_protocol.h`.

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/dma/ti/k3-udma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index e17b99de47..06f81431be 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -21,7 +21,6 @@
 #include <linux/bitmap.h>
 #include <driver.h>
 #include <linux/device.h>
-#include <soc/ti/ti_sci_protocol.h>
 
 #include "k3-udma-hwdef.h"
 #include "k3-psil-priv.h"
-- 
2.48.1

[PATCH v2 2/3] dma-devices: k3-udma: use snprintf instead of sprintf

[Jules Maselbas]

Replace the use of sprintf by snprintf, in this case sprintf could not
overflow because the size of uc::name is well chosen to be able to fit
the largest u32 integer.

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/dma/ti/k3-udma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 06f81431be..7e6a08348a 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -2678,7 +2678,7 @@ static int k3_udma_probe(struct device *dev)
 		uc->config.mapped_channel_id = -1;
 		uc->config.default_flow_id = -1;
 		uc->config.dir = DMA_MEM_TO_MEM;
-		sprintf(uc->name, "UDMA chan%d\n", i);
+		snprintf(uc->name, sizeof(uc->name), "UDMA chan%d\n", i);
 		if (!i)
 			uc->in_use = true;
 	}
-- 
2.48.1

[PATCH v2 3/3] pmdomain: ti-k3: remove trailing whitespace

[Jules Maselbas]

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/pmdomain/ti/ti-k3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pmdomain/ti/ti-k3.c b/drivers/pmdomain/ti/ti-k3.c
index 1616e90b62..39fd9f329b 100644
--- a/drivers/pmdomain/ti/ti-k3.c
+++ b/drivers/pmdomain/ti/ti-k3.c
@@ -321,14 +321,14 @@ static int ti_k3_pm_domain_on(struct generic_pm_domain *domain)
 	struct ti_k3_pm_domain *pd = to_ti_k3_pd(domain);
 
 	return ti_lpsc_transition(pd->lpsc, MDSTAT_STATE_ENABLE);
-}       
-        
+}
+
 static int ti_k3_pm_domain_off(struct generic_pm_domain *domain)
-{       
+{
 	struct ti_k3_pm_domain *pd = to_ti_k3_pd(domain);
 
 	return ti_lpsc_transition(pd->lpsc, MDSTAT_STATE_SWRSTDISABLE);
-}       
+}
 
 static struct ti_psc am625_psc[] = {
 	[0] = { .id = 0, .base = (void *)0x04000000 },
-- 
2.48.1