mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] regulator: fan53555: suppress warning about uninitialized variable
@ 2025-03-14 15:24 Jules Maselbas
  0 siblings, 0 replies; only message in thread
From: Jules Maselbas @ 2025-03-14 15:24 UTC (permalink / raw)
  To: barebox; +Cc: Jules Maselbas

In function 'fan53555_device_setup', a call to 'regmap_update_bits' is
made with the mode_mask variable potentially uninitialized.

This can be the case if di->vendor is FAN53526_VENDOR_FAIRCHILD and
di->sleep_vsel_id is not handled by the case (neither FAN53555_VSEL_ID_0 nor FAN53555_VSEL_ID_1).
I am not sure how likely it is to happen.

Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 drivers/regulator/fan53555.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
index 2df0d2410a..2dcc6f5394 100644
--- a/drivers/regulator/fan53555.c
+++ b/drivers/regulator/fan53555.c
@@ -238,7 +238,7 @@ static const struct regulator_ops fan53555_regulator_ops = {
 
 static int fan53555_device_setup(struct fan53555_device_info *di)
 {
-	unsigned int mode_reg, mode_mask;
+	unsigned int mode_reg, mode_mask = 0;
 	int ret = 0;
 
 	/* Setup voltage control register */
-- 
2.48.1




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-14 15:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-14 15:24 [PATCH] regulator: fan53555: suppress warning about uninitialized variable Jules Maselbas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox