mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] partition: fix reference to wrong cdev in warning message
@ 2025-03-18  8:24 Ahmad Fatoum
  2025-03-18 10:22 ` Sascha Hauer
  2025-03-18 11:16 ` Uwe Kleine-König
  0 siblings, 2 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2025-03-18  8:24 UTC (permalink / raw)
  To: barebox; +Cc: Uwe Kleine-König, Ahmad Fatoum

For MBR and GPT, barebox creates links to the partitions, so they can be
referenced both by index and partition label.

Failing to create a link is not an error, but results in a warning
message. The current message claims that the link was pointing at the
parent block device's cdev, but it actually was pointing at the child
partition. Fix that.

Reported-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/partitions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/partitions.c b/common/partitions.c
index 7562536cf9b8..bc90f51f6112 100644
--- a/common/partitions.c
+++ b/common/partitions.c
@@ -63,7 +63,7 @@ static int register_one_partition(struct block_device *blk, struct partition *pa
 	ret = devfs_create_link(cdev, partition_name);
 	if (ret)
 		dev_warn(blk->dev, "Failed to create link from %s to %s\n",
-			 partition_name, blk->cdev.name);
+			 partition_name, cdev->name);
 	free(partition_name);
 
 	return 0;
-- 
2.39.5




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-03-18 11:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-18  8:24 [PATCH master] partition: fix reference to wrong cdev in warning message Ahmad Fatoum
2025-03-18 10:22 ` Sascha Hauer
2025-03-18 11:16 ` Uwe Kleine-König
2025-03-18 11:23   ` Ahmad Fatoum
2025-03-18 11:31     ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox