mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 1/8] firmware: disable MISSING_FIRMWARE_ERROR for COMPILE_TEST builds
Date: Thu, 20 Mar 2025 06:16:34 +0100	[thread overview]
Message-ID: <20250320051641.1721377-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20250320051641.1721377-1-a.fatoum@pengutronix.de>

An allyes build will enable all options possible and thus usually fail
to build, because it enables CONFIG_MISSING_FIRMWARE_ERROR along with
DRIVER_NET_FSL_FMAN, which requires firmware to function at runtime.

Fix this by disabling MISSING_FIRMWARE_ERROR if COMPILE_TEST is enabled.
This works, because Kconfig encounters COMPILE_TEST first.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - no change
---
 firmware/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/firmware/Kconfig b/firmware/Kconfig
index ba005976c5a1..9253bc14cb0c 100644
--- a/firmware/Kconfig
+++ b/firmware/Kconfig
@@ -9,6 +9,8 @@ config EXTRA_FIRMWARE_DIR
 config MISSING_FIRMWARE_ERROR
 	bool "Fail the build when required firmware is missing"
 	default y
+	# This prevents firmware errors from breaking allyesconfig builds
+	depends on !COMPILE_TEST
 	help
 	  In-tree Defconfigs that enable multiple boards with different firmware
 	  binary requirements would say y here, so you don't need unrelated firmware
-- 
2.39.5




  reply	other threads:[~2025-03-20  5:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20  5:16 [PATCH master 0/8] treewide: misc fixes Ahmad Fatoum
2025-03-20  5:16 ` Ahmad Fatoum [this message]
2025-03-20  5:16 ` [PATCH master 2/8] include: asm-generic/pointer.h: fix ASM_PTR definition for i386 Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 3/8] sandbox: do not enable SANDBOX_LINUX_I386 in allyesconfig Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 4/8] Documentation: devicetree: fix Sphinx warnings Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 5/8] ARM: mvebu: kwb_bbu: add missing header Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 6/8] net: phy: fix of_get_phy_mode for XLGMII and beyond Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 7/8] vsprintf: fix left indentation when formatting wide string arguments Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 8/8] test: self: printf: add tests for formatting wide strings Ahmad Fatoum
2025-03-20 11:46 ` [PATCH master 0/8] treewide: misc fixes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250320051641.1721377-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox