mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH master 3/8] sandbox: do not enable SANDBOX_LINUX_I386 in allyesconfig
Date: Thu, 20 Mar 2025 06:16:36 +0100	[thread overview]
Message-ID: <20250320051641.1721377-4-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20250320051641.1721377-1-a.fatoum@pengutronix.de>

On sandbox, CONFIG_32BIT and CONFIG_64BIT are determined by the used
compiler. As special case, building sandbox on x86_64 allows
selecting a 32-bit build via CONFIG_SANDBOX_LINUX_I386 if the compiler
supports it.

This option is disabled by default, but allyesconfig turns it on,
alongside drivers requiring host libraries like FTDI and SDL, which
are usually not required.

To make allyesconfig work out-of-the-box, restructure the config
symbols and give 64BIT a prompt only if i386 support is possible.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - fix typo in symbol name (32_BIT -> 32BIT)
---
 arch/sandbox/Kconfig | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig
index c1a51d4f021d..d4380aba0b5f 100644
--- a/arch/sandbox/Kconfig
+++ b/arch/sandbox/Kconfig
@@ -44,17 +44,23 @@ config CC_HAS_LINUX_I386_SUPPORT
 
 config 64BIT
 	bool
-	default n if SANDBOX_LINUX_I386
+	prompt "64-bit barebox" if CC_HAS_LINUX_I386_SUPPORT
 	default CC_IS_64BIT
 	select ARCH_DMA_ADDR_T_64BIT
 	select PHYS_ADDR_T_64BIT
 	select ARCH_HAS_ASAN_FIBER_API if ASAN
+	help
+	  Say n here if you want to build a 32-bit barebox, either
+	  to be more similar to a target platform or to reduce
+	  memory usage when fuzzing for example.
+
+	  If unsure, say y.
 
 config 32BIT
 	def_bool !64BIT
 
 config SANDBOX_LINUX_I386
-	bool "32-bit x86 barebox" if CC_HAS_LINUX_I386_SUPPORT
+	def_bool 32BIT && CC_HAS_LINUX_I386_SUPPORT
 
 config SANDBOX_REEXEC
 	prompt "exec(2) reset handler"
-- 
2.39.5




  parent reply	other threads:[~2025-03-20  5:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20  5:16 [PATCH master 0/8] treewide: misc fixes Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 1/8] firmware: disable MISSING_FIRMWARE_ERROR for COMPILE_TEST builds Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 2/8] include: asm-generic/pointer.h: fix ASM_PTR definition for i386 Ahmad Fatoum
2025-03-20  5:16 ` Ahmad Fatoum [this message]
2025-03-20  5:16 ` [PATCH master 4/8] Documentation: devicetree: fix Sphinx warnings Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 5/8] ARM: mvebu: kwb_bbu: add missing header Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 6/8] net: phy: fix of_get_phy_mode for XLGMII and beyond Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 7/8] vsprintf: fix left indentation when formatting wide string arguments Ahmad Fatoum
2025-03-20  5:16 ` [PATCH master 8/8] test: self: printf: add tests for formatting wide strings Ahmad Fatoum
2025-03-20 11:46 ` [PATCH master 0/8] treewide: misc fixes Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250320051641.1721377-4-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox